Skip to content

Basic implementation to make Watchdog BackgroundResources#22

Open
rahulKQL wants to merge 4 commits into
masterfrom
watchdog
Open

Basic implementation to make Watchdog BackgroundResources#22
rahulKQL wants to merge 4 commits into
masterfrom
watchdog

Conversation

@rahulKQL
Copy link
Copy Markdown
Owner

@rahulKQL rahulKQL commented Jan 2, 2020

to discuss the implementation details

Copy link
Copy Markdown

@pmakani pmakani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This change updates watchdog to BackgroundResource, Also, watchdog unschedules itself explicitly when shutdown.

closes googleapis#828
Copy link
Copy Markdown

@pmakani pmakani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants