Name clash with `std::vector`

[lionel-]

I find it a bit confusing to read code with a templated class called vector that is not std::vector. How about cpp11::r_vector<>?

[jimhester]

Sorry, my first reply was too harsh.

I thought about this when I was writing it, but decided that namespaces gave it enough disambiguation. I deliberately always use the fully qualified name when using std::vectors in the internal code for this reason.

We could probably also always use the fully qualified name internally when dealing with cpp11::vectors, just to make it completely clear which vector we are talking about at all times.

Also I feel like the fact that the class template is really only internal makes this less severe, users will only see the non templated typedefs in their code and error messages.

[lionel-]

If it's only internal it's not that big a deal I guess. But I still think important class names should be unique even with the namespaces, otherwise reading code requires context switching.

[jimhester]

The internal name does come up in error messages, even though the typedef is also shown e.g.

no known conversion from 'cpp11::writable::list' (aka 'vector<SEXPREC *>') 

So I think it might be worth renaming to r_vector to make that case more clear.