fix(test): skip cumsum tests on TensorRT-RTX Windows instead of xfail#4189
Merged
lanluo-nvidia merged 1 commit intopytorch:mainfrom Apr 15, 2026
Merged
Conversation
Change TestCumsumConverter from @pytest.mark.xfail to @unittest.skipIf. With xfail, the test still runs and the cumsum error corrupts CUDA state, causing subsequent tests in the pipeline to fail. Skipping avoids running the test entirely and prevents the cascading failures. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change
TestCumsumConverterfrom@pytest.mark.xfailto@unittest.skipIfto match the repo convention for TensorRT-RTX conditional test skips.With
xfail, the cumsum test still executes and the resulting error corrupts CUDA state, causing subsequent tests in the CI pipeline to fail. UsingskipIfavoids running the test entirely and prevents these cascading failures.Type of change
Checklist: