mailbox: Couple small fixes#3490
Merged
JelleZijlstra merged 2 commits intopython:masterfrom Nov 25, 2019
Merged
Conversation
These HasIteritems and HasItems protocols don't exist in the real mailbox module so prefix them with underscore to indicate they are private.
The Mailbox.add and Mailbox.__setitem__ methods take a message argument which can be anything that is convertible to a Message. Fix the signatures accordingly.
Member
|
cc @CraftSpider who contributed the stubs. |
Contributor
|
Double checked the source/docs, and looks good to me. |
CraftSpider
approved these changes
Nov 25, 2019
Member
|
Thanks for the PR and review! |
Contributor
Author
|
Thanks for reviewing and merging this so quickly! It occurred to me while reading the review that there's still one more place that should be fixed accordingly, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix type of the message argument in couple methods and make the stub-only helpers private by prefixing them with underscore.