Merged
Conversation
Contributor
Author
|
Pytype failure is unusual, opened a bug google/pytype#444 |
JelleZijlstra
requested changes
Nov 6, 2019
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Thank you for the PR! I left some suggestions.
Contributor
Author
|
Any updates on this? I believe all review concerns were addressed, though I understand if you're just busy/taking a break. |
JelleZijlstra
approved these changes
Nov 23, 2019
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Sorry for the delay! I noticed one small issue, which I just committed a fix for. I'll merge after the tests pass.
| class MaildirMessage(Message): | ||
|
|
||
| def get_subdir(self) -> str: ... | ||
| def set_subdir(self, subdir: Union[Literal["new", "cur"]]) -> None: ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add stubs for the
mailboxmodule. My first contribution using new Protocols and Generics