Refactor: Extract a StatusLineFormatter - #16186
Open
srittau wants to merge 3 commits into
Open
Conversation
This formatter is a context manager that ensures that in scripts that process multiple items, each item has a proper "item name... status" line that is not interrupted by additional output. Any additional output is printed in usually muted colors below the initial status line. Currently, this is only implemented for stubtest_third_party, where this was already implemented correctly manually, but this will prove very useful for stubsabot, which currently has a few bugs related to command output that will be hard to fix manually. This is not a strict refactoring, as it changes a few strings and colors for better consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This formatter is a context manager that ensures that in scripts that process multiple items, each item has a proper "item name... status" line that is not interrupted by additional output. Any additional output is printed in usually muted colors below the initial status line.
Currently, this is only implemented for stubtest_third_party, where this was already implemented correctly manually, but this will prove very useful for stubsabot, which currently has a few bugs related to command output that will be hard to fix manually.
This is not a strict refactoring, as it changes a few strings and colors for better consistency.