Skip to content

[CI] "pyright: Run test cases" task doesn't install apt dependencies #13973

Description

@srittau

The step "Install 3rd-party stub dependencies" of the "pyright: Run test cases" task in the tests.yml workflow doesn't install the tool.stubtest.apt_dependencies before trying to install the Python packages, leading to potential errors when they are required for building the package. Cf. #13957

Activity

  1. srittau commented on May 9, 2025

    @srittau
    CollaboratorAuthor

    That said, this makes some sense as the task in question is unrelated to stubtest. But the problem remains regardless. We should maybe move the apt_dependencies key out of tool.stubtest. Maybe rename to test_apt_dependencies and move to top level?

  2. JelleZijlstra commented on May 9, 2025

    @JelleZijlstra
    Member

    Bikeshed: Maybe put it in tool.typeshed.

  3. srittau commented on May 9, 2025

    @srittau
    CollaboratorAuthor

    Well, METADATA.toml is specific to typeshed, so that would be kind of redundant.

  4. added a commit that references this issue on May 9, 2025
    a8f3f20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    project: infrastructuretypeshed build, test, documentation, or distribution related

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions