Skip to content

Keep 404 legacy links on the legacy host#3018

Merged
JacobCoffee merged 2 commits into
python:mainfrom
e-q:keep-legacy-404-links-on-legacy-host
Jun 4, 2026
Merged

Keep 404 legacy links on the legacy host#3018
JacobCoffee merged 2 commits into
python:mainfrom
e-q:keep-legacy-404-links-on-legacy-host

Conversation

@e-q
Copy link
Copy Markdown
Contributor

@e-q e-q commented Jun 2, 2026

Description

  • Build custom 404 legacy-site links by quoting the request path and appending
    it to the fixed legacy.python.org origin.
  • Add focused regression tests for encoded-slash and decoded leading-slash
    paths.

Closes

Testing

  • Focused 404 view/helper regression tests: passed.
  • Focused Ruff lint and format checks on touched files: passed.
  • Whitespace check: passed.

@e-q e-q requested a review from JacobCoffee as a code owner June 2, 2026 18:25
Copy link
Copy Markdown
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM.

Comment thread apps/cms/tests.py
@JacobCoffee JacobCoffee merged commit 428656f into python:main Jun 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: 404 legacy website link can point to an external site

3 participants