Repository navigation
Add basic implementation for mypy: ignore comments - #22180
Open
ilevkivskyi wants to merge 2 commits into
Open
ilevkivskyi wants to merge 2 commits into
ilevkivskyi wants to merge 2 commits into
Conversation
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: sockeye (https://github.com/awslabs/sockeye)
+ sockeye/layers.py:642: error: Unused "type: ignore" comment [unused-ignore]
scipy-stubs (https://github.com/scipy/scipy-stubs)
+ tests/misc/test_submodules_empty.pyi:3: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12358
Implementation is mostly straightforward, but there are few things:
6. This is trivial however, functions now have a flag indicating if they have a type comment.Finally, there is one thing that bothers me a bit: we have few places where we mention words
type: ignorein errors and notes. However, it would take a significant effort to reliably change them tomypy: ignorewhen needed. Essentially we would need to record provenance for each error code, and thread it through to many places (including to cache metas, for some technical reasons). So we have three options:mypy: ignorereally means mypy-specific type ignore, so it is fine to usetype: ignorein error notes, if we actually havemypy: ignorewritten in code.Unused "ignore" commentinstead ofUnused "type: ignore" commentetc.I am leaning towards option 3, but wanted to double-check before actually doing this.
cc @JukkaL