Skip to content

False positive with warn unreachable, Any, and None #20532

Closed
#20643
Closed
False positive with warn unreachable, Any, and None#20532
#20643
Labels
bugmypy got something wrongtopic-reachabilityDetecting unreachable code

Description

@hauntsaninja
hauntsaninja
opened on Jan 6, 2026
from typing import Any

def main(contents: Any, commit: str | None) -> None:
    if (
        contents.get("commit") == commit
        and (commit is not None or print("can_be_reached"))
    ):
        pass

main({"commit": None}, None)

mypy 1.19.1 with --warn-unreachable gives main.py:6: error: Right operand of "or" is never evaluated [unreachable]

Activity

  1. hauntsaninja
    added
    bugmypy got something wrong
    topic-reachabilityDetecting unreachable code
    on Jan 6, 2026

  2. calm329 commented on Jan 6, 2026

    @calm329
    calm329
    on Jan 6, 2026

    @hauntsaninja I've fixed the issue, could you check it please?

  3. calm329 commented on Jan 6, 2026

    @calm329
    calm329
    on Jan 6, 2026

    @hauntsaninja Please let me know when you are available to review my pr

  4. hauntsaninja
    closed this as completedin #20643on Jan 27, 2026
  5. hauntsaninja
    added a commit that references this issue on Jan 27, 2026

    Better narrowing with custom equality (python#20643)

    e64a84b

  6. FMorgan-111 commented on Jul 4, 2026

    @FMorgan-111
    FMorgan-111
    on Jul 4, 2026 · Hidden as spam

  7. FMorgan-111 commented on Jul 4, 2026

    @FMorgan-111
    FMorgan-111
    on Jul 4, 2026 · Hidden as spam

  8. FMorgan-111 commented on Jul 5, 2026

    @FMorgan-111
    FMorgan-111
    on Jul 5, 2026 · Hidden as spam

  9. FMorgan-111 commented on Jul 5, 2026

    @FMorgan-111
    FMorgan-111
    on Jul 5, 2026 · Hidden as spam

  10. FMorgan-111 commented on Jul 5, 2026

    @FMorgan-111
    FMorgan-111
    on Jul 5, 2026 · Hidden as spam

  11. FMorgan-111 commented on Jul 5, 2026

    @FMorgan-111
    FMorgan-111
    on Jul 5, 2026 · Hidden as spam

  12. FMorgan-111 commented on Jul 5, 2026

    @FMorgan-111
    FMorgan-111
    on Jul 5, 2026 · Hidden as spam

  13. FMorgan-111 commented on Jul 5, 2026

    @FMorgan-111
    FMorgan-111
    on Jul 5, 2026 · Hidden as spam

  14. FMorgan-111 commented on Jul 5, 2026

    @FMorgan-111
    FMorgan-111
    on Jul 5, 2026 · Hidden as spam

  15. FMorgan-111 commented on Jul 5, 2026

    @FMorgan-111
    FMorgan-111
    on Jul 5, 2026 · Hidden as spam

  16. FMorgan-111 commented on Jul 5, 2026

    @FMorgan-111
    FMorgan-111
    on Jul 5, 2026 · Hidden as spam

  17. FMorgan-111 commented on Jul 5, 2026

    @FMorgan-111
    FMorgan-111
    on Jul 5, 2026 · Hidden as spam

  18. FMorgan-111 commented on Jul 5, 2026

    @FMorgan-111
    FMorgan-111
    on Jul 5, 2026 · Hidden as spam

  19. FMorgan-111 commented on Jul 5, 2026

    @FMorgan-111
    FMorgan-111
    on Jul 5, 2026 · Hidden as spam

  20. FMorgan-111 commented on Jul 5, 2026

    @FMorgan-111
    FMorgan-111
    on Jul 5, 2026 · Hidden as spam

  21. FMorgan-111 commented on Jul 6, 2026

    @FMorgan-111
    FMorgan-111
    on Jul 6, 2026 · Hidden as spam

  22. FMorgan-111 commented on Jul 6, 2026

    @FMorgan-111
    FMorgan-111
    on Jul 6, 2026 · Hidden as spam

  23. FMorgan-111 commented on Jul 6, 2026

    @FMorgan-111
    FMorgan-111
    on Jul 6, 2026 · Hidden as spam

  24. FMorgan-111 commented on Jul 6, 2026

    @FMorgan-111
    FMorgan-111
    on Jul 6, 2026 · Hidden as spam

  25. FMorgan-111 commented on Jul 20, 2026

    @FMorgan-111
    FMorgan-111
    on Jul 20, 2026

    RepoPilot v2 could not complete an automatic fix.

    Reason: Failed to read issue:

    Relevant files:
    None found

    Attempts:
    No patch attempts were made.

    Token usage: 0/50000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugmypy got something wrongtopic-reachabilityDetecting unreachable code

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions