Skip to content

gh-91731: Don't define 'static_assert' in C++11 where is a keyword to avoid UB#93700

Merged
pablogsal merged 2 commits into
python:mainfrom
pablogsal:91731
Jun 13, 2022
Merged

gh-91731: Don't define 'static_assert' in C++11 where is a keyword to avoid UB#93700
pablogsal merged 2 commits into
python:mainfrom
pablogsal:91731

Conversation

@pablogsal

Copy link
Copy Markdown
Member

No description provided.

Comment thread Include/pymacro.h
Comment thread Include/pymacro.h Outdated
Comment thread Include/pymacro.h

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can move this NEWS entry to Build, or C API, category.

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@pablogsal pablogsal added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Jun 16, 2022
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@pablogsal pablogsal deleted the 91731 branch June 16, 2022 14:25
@bedevere-bot

Copy link
Copy Markdown

GH-93907 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 16, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 16, 2022
…ord to avoid UB (pythonGH-93700)

(cherry picked from commit 65ff27c)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants