gh-93573: Replace wrong example domains in configparser doc#93574
Merged
Conversation
Member
Maybe, |
Member
|
Documentation should use reserved TLDs from https://datatracker.ietf.org/doc/html/rfc2606, e.g. |
topsecret.server.com domain is not controled by PSF. It's replaced by invalid topsecret.server.example domain. It follows RFC 2606, which advise .example as TLD for documentation.
Contributor
Author
|
I replaced I don't think news are needed. |
AA-Turner
approved these changes
Jun 7, 2022
AA-Turner
left a comment
AA-Turner
left a comment
Member
There was a problem hiding this comment.
If we're changing to .example, it might also be worth changing the bitbucket.org ones? I know the domain is currently active, but extra safety doesn't hurt.
A
Contributor
Author
|
|
AA-Turner
added
needs backport to 3.10
sblondon
changed the title
Member
|
IMHO |
Contributor
Author
MYavuzYAGIS
approved these changes
Jun 28, 2022
merwok
changed the title
Contributor
Author
|
The bytebong.com domain is now available to everyone: Should I ping a core reviewer for the merge? |
JulienPalard
approved these changes
Feb 16, 2023
Contributor
|
Thanks @sblondon for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-101953 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 16, 2023
…thonGH-93574) * Replace bitbucket.org domain by forge.example * Update example to python.org * Use explicitly invalid domain topsecret.server.com domain is not controled by PSF. It's replaced by invalid topsecret.server.example domain. It follows RFC 2606, which advise .example as TLD for documentation. (cherry picked from commit 924a3bf) Co-authored-by: sblondon <stephane.blondon@gmail.com>
|
GH-101954 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 16, 2023
…thonGH-93574) * Replace bitbucket.org domain by forge.example * Update example to python.org * Use explicitly invalid domain topsecret.server.com domain is not controled by PSF. It's replaced by invalid topsecret.server.example domain. It follows RFC 2606, which advise .example as TLD for documentation. (cherry picked from commit 924a3bf) Co-authored-by: sblondon <stephane.blondon@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Feb 16, 2023
* Replace bitbucket.org domain by forge.example * Update example to python.org * Use explicitly invalid domain topsecret.server.com domain is not controled by PSF. It's replaced by invalid topsecret.server.example domain. It follows RFC 2606, which advise .example as TLD for documentation. (cherry picked from commit 924a3bf) Co-authored-by: sblondon <stephane.blondon@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Feb 16, 2023
* Replace bitbucket.org domain by forge.example * Update example to python.org * Use explicitly invalid domain topsecret.server.com domain is not controled by PSF. It's replaced by invalid topsecret.server.example domain. It follows RFC 2606, which advise .example as TLD for documentation. (cherry picked from commit 924a3bf) Co-authored-by: sblondon <stephane.blondon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This minor PR replaces bytebong.com to python.org in configparser example in order to use a domain the PSF controls.
topsecret.server.comis obviously an example and I don't thinkbitbucket.orgis a risk currently so they are not modified.