bpo-30780: Add IDLE configdialog tests by csabella · Pull Request #3592 · python/cpython

csabella · 2017-09-14T23:29:55Z

Expose dialog buttons to test code. Complete coverage for highlight and keys tabs
and for buttons and their functions.

https://bugs.python.org/issue30780

vstinner · 2019-01-10T16:05:52Z

I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches

…g and add tests for buttons.

terryjreedy · 2020-01-25T20:27:56Z

I fixed the overt conflicts with the web editor. I fixed the failure on my local branch. I forgot that patch can only be used to temporarily replace existing attribute, not temporarily add new attribute. I intend to add context manager to idle_test.mock_idle for the latter, so we don't have to explicitly delete when instance is persistent across tests, as dialog is. I am now reviewing other tests and will add blurb and NEWS.txt items and update coverage when ready to commit.

and deleted unneeded keys test code. This does opposite.

terryjreedy

I still need to look at the new test_delete_custom_theme/keys code.

terryjreedy

Will merge when CI passes again.

terryjreedy · 2020-01-27T21:35:07Z

+        theme_name2 = 'other theme'
+        idleConf.userCfg['highlight'].SetOption(theme_name2, 'name', 'value')
+        highpage[theme_name2] = {'option': 'False'}
+


This and the corresponding additions for keys cover the failure of if not item_list and the else clause. I suspect it could be done in fewer lines, but I hope to someday factor out the common code, simpfiy the UI, and redo the tests anyway. So leave the additions alone.

bedevere-bot · 2020-01-27T22:16:00Z

@terryjreedy: Please replace # with GH- in the commit message next time. Thanks!

miss-islington · 2020-01-27T22:16:00Z

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington · 2020-01-27T22:16:01Z

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

Expose dialog buttons to test code and complete their test coverage. Complete test coverage for highlights and keys tabs. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit dd023ad) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>

bedevere-bot · 2020-01-27T22:16:14Z

GH-18218 is a backport of this pull request to the 3.7 branch.

miss-islington · 2020-01-27T22:17:52Z

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

bedevere-bot · 2020-01-27T22:18:01Z

GH-18219 is a backport of this pull request to the 3.8 branch.

Expose dialog buttons to test code and complete their test coverage. Complete test coverage for highlights and keys tabs. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit dd023ad) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>

csabella · 2020-01-28T00:07:14Z

Terry, thanks for merging this! 🙂

Expose dialog buttons to test code and complete their test coverage. Complete test coverage for highlights and keys tabs. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

Restore the placeholder import in idlelib/idle_test/template.py It was removed as an unused import in GH-151478, but template.py is a skeleton for creating new IDLE test files, and idle_test/README.txt instructs the user to replace 'zzdummy' with the name of the module under test. Add a Ruff per-file ignore to keep it. test_editor.RMenuTest was added in GH-18951, which fixed right-clicking inside a selection, with the note that an automated test should follow. Use the DummyRMenu class left there to test right_menu_event(), and test the rmenu_check_*() methods that supply the menu entry states. test_configdialog.ConfigDialogTest was left with two empty stubs in GH-3592, named after the two ConfigDialog methods which the button tests only check to be called. Test them with a fake parent whose instance dictionary contains an autospecced EditorWindow. test_configdialog.ExtPageTest was added empty, with a commented-out "Nothing here yet TODO" skip, when ExtPage was factored out of ConfigDialog in GH-26618. Test load_extensions(), extension_selected(), set_extension_value() and save_all_changed_extensions(). test_grep.Default_commandTest was left empty in 2013 because GrepDialog.default_command() imports OutputWindow when called, and the import cannot be moved to the top of the module due to an import loop. Replace the imported class with a mock instead of moving the import. test_config.ChangesTest.test_save_default never called save_all(), so it tested nothing. Add the missing assertions, and add the test for the Save() calls that the following TODO comment asked for. test_config.IdleConfTest.test_get_current_keyset only tested the non-darwin branch, because the default key sets no longer contain Alt keys. Add an extension binding with an Alt key, so that its replacement with Option can be tested. Remove the stale commented-out test in test_get_extension_keys, which used the ZoomHeight extension. --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: TerryJReedy <tjreedy@udel.edu>

…) (#157205) Restore the placeholder import in idlelib/idle_test/template.py It was removed as an unused import in GH-151478, but template.py is a skeleton for creating new IDLE test files, and idle_test/README.txt instructs the user to replace 'zzdummy' with the name of the module under test. Add a Ruff per-file ignore to keep it. test_editor.RMenuTest was added in GH-18951, which fixed right-clicking inside a selection, with the note that an automated test should follow. Use the DummyRMenu class left there to test right_menu_event(), and test the rmenu_check_*() methods that supply the menu entry states. test_configdialog.ConfigDialogTest was left with two empty stubs in GH-3592, named after the two ConfigDialog methods which the button tests only check to be called. Test them with a fake parent whose instance dictionary contains an autospecced EditorWindow. test_configdialog.ExtPageTest was added empty, with a commented-out "Nothing here yet TODO" skip, when ExtPage was factored out of ConfigDialog in GH-26618. Test load_extensions(), extension_selected(), set_extension_value() and save_all_changed_extensions(). test_grep.Default_commandTest was left empty in 2013 because GrepDialog.default_command() imports OutputWindow when called, and the import cannot be moved to the top of the module due to an import loop. Replace the imported class with a mock instead of moving the import. test_config.ChangesTest.test_save_default never called save_all(), so it tested nothing. Add the missing assertions, and add the test for the Save() calls that the following TODO comment asked for. test_config.IdleConfTest.test_get_current_keyset only tested the non-darwin branch, because the default key sets no longer contain Alt keys. Add an extension binding with an Alt key, so that its replacement with Option can be tested. Remove the stale commented-out test in test_get_extension_keys, which used the ZoomHeight extension. --------- (cherry picked from commit f8f8c30)

…) (#157206) Restore the placeholder import in idlelib/idle_test/template.py It was removed as an unused import in GH-151478, but template.py is a skeleton for creating new IDLE test files, and idle_test/README.txt instructs the user to replace 'zzdummy' with the name of the module under test. Add a Ruff per-file ignore to keep it. test_editor.RMenuTest was added in GH-18951, which fixed right-clicking inside a selection, with the note that an automated test should follow. Use the DummyRMenu class left there to test right_menu_event(), and test the rmenu_check_*() methods that supply the menu entry states. test_configdialog.ConfigDialogTest was left with two empty stubs in GH-3592, named after the two ConfigDialog methods which the button tests only check to be called. Test them with a fake parent whose instance dictionary contains an autospecced EditorWindow. test_configdialog.ExtPageTest was added empty, with a commented-out "Nothing here yet TODO" skip, when ExtPage was factored out of ConfigDialog in GH-26618. Test load_extensions(), extension_selected(), set_extension_value() and save_all_changed_extensions(). test_grep.Default_commandTest was left empty in 2013 because GrepDialog.default_command() imports OutputWindow when called, and the import cannot be moved to the top of the module due to an import loop. Replace the imported class with a mock instead of moving the import. test_config.ChangesTest.test_save_default never called save_all(), so it tested nothing. Add the missing assertions, and add the test for the Save() calls that the following TODO comment asked for. test_config.IdleConfTest.test_get_current_keyset only tested the non-darwin branch, because the default key sets no longer contain Alt keys. Add an extension binding with an Alt key, so that its replacement with Option can be tested. Remove the stale commented-out test in test_get_extension_keys, which used the ZoomHeight extension. --------- Co-authored-by: Claude Opus 5 (1M context) noreply@anthropic.com Co-authored-by: Hugo van Kemenade 1324225+hugovk@users.noreply.github.com Co-authored-by: TerryJReedy tjreedy@udel.edu Co-authored-by: Serhiy Storchaka storchaka@gmail.com (cherry picked from commit f8f8c30)

…) (#157204) Restore the placeholder import in idlelib/idle_test/template.py It was removed as an unused import in GH-151478, but template.py is a skeleton for creating new IDLE test files, and idle_test/README.txt instructs the user to replace 'zzdummy' with the name of the module under test. Add a Ruff per-file ignore to keep it. test_editor.RMenuTest was added in GH-18951, which fixed right-clicking inside a selection, with the note that an automated test should follow. Use the DummyRMenu class left there to test right_menu_event(), and test the rmenu_check_*() methods that supply the menu entry states. test_configdialog.ConfigDialogTest was left with two empty stubs in GH-3592, named after the two ConfigDialog methods which the button tests only check to be called. Test them with a fake parent whose instance dictionary contains an autospecced EditorWindow. test_configdialog.ExtPageTest was added empty, with a commented-out "Nothing here yet TODO" skip, when ExtPage was factored out of ConfigDialog in GH-26618. Test load_extensions(), extension_selected(), set_extension_value() and save_all_changed_extensions(). test_grep.Default_commandTest was left empty in 2013 because GrepDialog.default_command() imports OutputWindow when called, and the import cannot be moved to the top of the module due to an import loop. Replace the imported class with a mock instead of moving the import. test_config.ChangesTest.test_save_default never called save_all(), so it tested nothing. Add the missing assertions, and add the test for the Save() calls that the following TODO comment asked for. test_config.IdleConfTest.test_get_current_keyset only tested the non-darwin branch, because the default key sets no longer contain Alt keys. Add an extension binding with an Alt key, so that its replacement with Option can be tested. Remove the stale commented-out test in test_get_extension_keys, which used the ZoomHeight extension. --------- (cherry picked from commit f8f8c30)

…56260) Restore the placeholder import in idlelib/idle_test/template.py It was removed as an unused import in pythonGH-151478, but template.py is a skeleton for creating new IDLE test files, and idle_test/README.txt instructs the user to replace 'zzdummy' with the name of the module under test. Add a Ruff per-file ignore to keep it. test_editor.RMenuTest was added in pythonGH-18951, which fixed right-clicking inside a selection, with the note that an automated test should follow. Use the DummyRMenu class left there to test right_menu_event(), and test the rmenu_check_*() methods that supply the menu entry states. test_configdialog.ConfigDialogTest was left with two empty stubs in pythonGH-3592, named after the two ConfigDialog methods which the button tests only check to be called. Test them with a fake parent whose instance dictionary contains an autospecced EditorWindow. test_configdialog.ExtPageTest was added empty, with a commented-out "Nothing here yet TODO" skip, when ExtPage was factored out of ConfigDialog in pythonGH-26618. Test load_extensions(), extension_selected(), set_extension_value() and save_all_changed_extensions(). test_grep.Default_commandTest was left empty in 2013 because GrepDialog.default_command() imports OutputWindow when called, and the import cannot be moved to the top of the module due to an import loop. Replace the imported class with a mock instead of moving the import. test_config.ChangesTest.test_save_default never called save_all(), so it tested nothing. Add the missing assertions, and add the test for the Save() calls that the following TODO comment asked for. test_config.IdleConfTest.test_get_current_keyset only tested the non-darwin branch, because the default key sets no longer contain Alt keys. Add an extension binding with an Alt key, so that its replacement with Option can be tested. Remove the stale commented-out test in test_get_extension_keys, which used the ZoomHeight extension. --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: TerryJReedy <tjreedy@udel.edu>

the-knights-who-say-ni added the CLA signed label Sep 14, 2017

bedevere-bot added the awaiting review label Sep 14, 2017

terryjreedy added the needs backport to 3.6 label Nov 29, 2017

terryjreedy self-assigned this May 20, 2018

terryjreedy added tests Tests in the Lib/test dir needs backport to 3.7 labels May 20, 2018

vstinner removed the needs backport to 3.6 label Jan 10, 2019

csabella added 2 commits January 19, 2020 12:47

bpo-30780: IDLE: Complete keys and highlight coverage for configdialo…

ef4584c

…g and add tests for buttons.

Correct tests due to other changes

648b850

csabella force-pushed the bpo30780 branch from 5f47a68 to 648b850 Compare January 19, 2020 18:09

csabella requested a review from terryjreedy as a code owner January 19, 2020 18:09

csabella mentioned this pull request Jan 25, 2020

bpo-39388: IDLE: Fix bug when cancelling out of configdialog #18068

Merged

terryjreedy added the needs backport to 3.8 label Jan 25, 2020

Merge branch 'master' into bpo30780

bcea0fb

terryjreedy changed the title ~~bpo-30780: IDLE: Complete keys and highlight coverage for configdialo…~~ bpo-30780: Add IDLE configdialog tests Jan 25, 2020

terryjreedy added 5 commits January 25, 2020 17:05

Fix test failure - cannot use patch for instance addition and deletion.

45e60ff

Use mock.patch.object as context manager.

5a8e94f

Test selection block bindings.

14e9efc

Eliminate reason to test with duplicate new names.

0b234eb

Complete last commit, which changed highlight code

168d07e

and deleted unneeded keys test code. This does opposite.

terryjreedy reviewed Jan 26, 2020

View reviewed changes

terryjreedy added 3 commits January 27, 2020 16:45

News items.

18499bf

Update NEWS.txt

60982c4

Update 2020-01-27-16-44-29.bpo-30780.nR80qu.rst

c7d7ce2

terryjreedy approved these changes Jan 27, 2020

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Jan 27, 2020

terryjreedy merged commit dd023ad into python:master Jan 27, 2020

bedevere-bot removed the awaiting merge label Jan 27, 2020

bedevere-bot removed the needs backport to 3.7 label Jan 27, 2020

terryjreedy added needs backport to 3.8 and removed needs backport to 3.8 labels Jan 27, 2020

bedevere-bot removed the needs backport to 3.8 label Jan 27, 2020

csabella deleted the bpo30780 branch January 28, 2020 00:06

serhiy-storchaka mentioned this pull request Aug 23, 2026

gh-155648: Write the empty and placeholder IDLE tests #156260

Merged

Uh oh!

Uh oh!

Conversation

csabella commented Sep 14, 2017 • edited by terryjreedy Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner commented Jan 10, 2019

Uh oh!

terryjreedy commented Jan 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

terryjreedy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

terryjreedy left a comment

Choose a reason for hiding this comment

Uh oh!

terryjreedy Jan 27, 2020

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Jan 27, 2020

Uh oh!

miss-islington commented Jan 27, 2020

Uh oh!

miss-islington commented Jan 27, 2020

Uh oh!

bedevere-bot commented Jan 27, 2020

Uh oh!

miss-islington commented Jan 27, 2020

Uh oh!

bedevere-bot commented Jan 27, 2020

Uh oh!

csabella commented Jan 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

csabella commented Sep 14, 2017 •

edited by terryjreedy

Loading

terryjreedy commented Jan 25, 2020 •

edited

Loading