bpo-31229: fix wrong error messages when too many keyword arguments are received#3180
Merged
Merged
Conversation
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
Just few style nits.
|
|
||
| def test_varargs14_kw(self): | ||
| msg = r"^product\(\) takes at most 1 keyword argument \(2 given\)$" | ||
| self.assertRaisesRegex(TypeError, msg, itertools.product, 0, a=1, b=2) |
Member
There was a problem hiding this comment.
I think it would be better to use names of supported arguments (and one unsupported).
|
|
||
| def test_varargs17_kw(self): | ||
| msg = r"^max\(\) takes at most 2 keyword arguments \(3 given\)$" | ||
| self.assertRaisesRegex(TypeError, msg, max, 0, a=1, b=2, c=3) |
Member
There was a problem hiding this comment.
I think it is enough to test only one of min()/max() functions.
| nargs = PyTuple_GET_SIZE(args); | ||
| nkwargs = (kwargs == NULL) ? 0 : PyDict_GET_SIZE(kwargs); | ||
| if (nargs + nkwargs > len) { | ||
| /* adding "keyword" (when nargs == 0) prevents producing wrong error |
Member
There was a problem hiding this comment.
Since the comment is a full sentence, start it by title case letter.
serhiy-storchaka
approved these changes
Aug 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
according to http://bugs.python.org/issue31229, fix the error messages produced when calling the following with too many keyword arguments:
https://bugs.python.org/issue31229