bpo-44011: New asyncio ssl implementation by kumaraditya303 · Pull Request #31275 · python/cpython

kumaraditya303 · 2022-02-11T12:20:20Z

Co-Authored-By: Andrew Svetlov andrew.svetlov@gmail.com

https://bugs.python.org/issue44011

Co-Authored-By: Andrew Svetlov <andrew.svetlov@gmail.com>

kumaraditya303 · 2022-02-11T12:21:46Z

@sobolevn Test with buildbots. Thanks

bedevere-bot · 2022-02-11T12:27:54Z

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 10db2f2 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

asvetlov · 2022-02-11T13:11:17Z

Thanks for picking this work up!

kumaraditya303 · 2022-02-11T15:00:16Z

cc @asvetlov The build-bots passed and are all green, ready for merge!

bedevere-bot · 2022-02-13T08:40:49Z

🤖 New build scheduled with the buildbot fleet by @asvetlov for commit 10db2f2 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

asvetlov

Looks good.
I've scheduled yet another buildbots round to make sure.

Also, please document the new ssh_shutdown_timeout

bedevere-bot · 2022-02-13T08:42:22Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

kumaraditya303 · 2022-02-14T06:56:29Z

@asvetlov I am busy currently so I suggest to land this and I'll prepare a PR for docs shortly.

sobolevn · 2022-02-14T07:47:33Z

This failure looks related: https://buildbot.python.org/all/#/builders/178/builds/435

asvetlov · 2022-02-14T08:08:53Z

@sobolevn why do you think so?
I read the following summary as everything is almost fine, test_concurrent_futures alters the environment.
The concurrent futures are not affected by this PR, I read this error as unrelated.

1 test altered the execution environment:
    test_concurrent_futures
14 tests skipped:
    test_devpoll test_ioctl test_kqueue test_msilib test_nis
    test_readline test_startfile test_tix test_tk test_ttk_guionly
    test_winconsoleio test_winreg test_winsound test_zipfile64
1 re-run test:
    test_unittest
    ```

kumaraditya303 · 2022-02-14T09:08:51Z

It is clearly unrelated.

asvetlov

Ok, lgtm

bedevere-bot · 2022-02-15T13:04:04Z

@asvetlov: Please replace # with GH- in the commit message next time. Thanks!

pythonGH-30297 removed a duplicate `from test import support` statement from `test_asyncio.test_sslproto`. However, in between that PR being filed and it being merged, pythonGH-31275 removed the _other_ `from test import support` statement. This means that `support` is now undefined in `test_asyncio.test_sslproto`, causing the CI to fail on all platforms for all PRS.

GH-30297 removed a duplicate `from test import support` statement from `test_asyncio.test_sslproto`. However, in between that PR being filed and it being merged, GH-31275 removed the _other_ `from test import support` statement. This means that `support` is now undefined in `test_asyncio.test_sslproto`, causing the CI to fail on all platforms for all PRS.

This reverts commit 13c10bf.

Some of the asyncio SSL changes in pythonGH-31275 were taken from [v0.16.0 of the uvloop project][1]. In order to comply with the MIT license, we need to just need to document the copyright information. [1]: https://github.com/MagicStack/uvloop/tree/v0.16.0

Some of the asyncio SSL changes in GH-31275 [1] were taken from v0.16.0 of the uvloop project [2]. In order to comply with the MIT license, we need to just need to document the copyright information. [1]: #31275 [2]: https://github.com/MagicStack/uvloop/tree/v0.16.0

…thonGH-107536) Some of the asyncio SSL changes in pythonGH-31275 [1] were taken from v0.16.0 of the uvloop project [2]. In order to comply with the MIT license, we need to just need to document the copyright information. [1]: python#31275 [2]: https://github.com/MagicStack/uvloop/tree/v0.16.0 (cherry picked from commit dce30c9) Co-authored-by: Alois Klink <alois@aloisklink.com>

…thonGH-107536) Some of the asyncio SSL changes in pythonGH-31275 [1] were taken from v0.16.0 of the uvloop project [2]. In order to comply with the MIT license, we need to just need to document the copyright information. [1]: python#31275 [2]: https://github.com/MagicStack/uvloop/tree/v0.16.0 (cherry picked from commit dce30c9)

… (#114045) Some of the asyncio SSL changes in GH-31275 [1] were taken from v0.16.0 of the uvloop project [2]. In order to comply with the MIT license, we need to just need to document the copyright information. [1]: #31275 [2]: https://github.com/MagicStack/uvloop/tree/v0.16.0 (cherry picked from commit dce30c9)

… (#114046) Some of the asyncio SSL changes in GH-31275 [1] were taken from v0.16.0 of the uvloop project [2]. In order to comply with the MIT license, we need to just need to document the copyright information. [1]: #31275 [2]: https://github.com/MagicStack/uvloop/tree/v0.16.0 (cherry picked from commit dce30c9)

…7536) Some of the asyncio SSL changes in pythonGH-31275 [1] were taken from v0.16.0 of the uvloop project [2]. In order to comply with the MIT license, we need to just need to document the copyright information. [1]: python#31275 [2]: https://github.com/MagicStack/uvloop/tree/v0.16.0

Some of the asyncio SSL changes in GH-31275 [1] were taken from v0.16.0 of the uvloop project [2]. In order to comply with the MIT license, we need to just need to document the copyright information. [1]: python/cpython#31275 [2]: https://github.com/MagicStack/uvloop/tree/v0.16.0 (cherry picked from commit dce30c9)

…7536) Some of the asyncio SSL changes in pythonGH-31275 [1] were taken from v0.16.0 of the uvloop project [2]. In order to comply with the MIT license, we need to just need to document the copyright information. [1]: python#31275 [2]: https://github.com/MagicStack/uvloop/tree/v0.16.0

kumaraditya303 and others added 3 commits February 11, 2022 12:17

bpo-44011: New asyncio ssl implementation

572ca54

Co-Authored-By: Andrew Svetlov <andrew.svetlov@gmail.com>

fix warning

aec4463

fix typo

10db2f2

the-knights-who-say-ni added the CLA signed label Feb 11, 2022

bedevere-bot added the awaiting review label Feb 11, 2022

sobolevn added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 11, 2022

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 11, 2022

kumaraditya303 marked this pull request as ready for review February 11, 2022 14:54

kumaraditya303 requested review from 1st1 and asvetlov as code owners February 11, 2022 14:54

asvetlov added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 13, 2022

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 13, 2022

asvetlov requested changes Feb 13, 2022

View reviewed changes

bedevere-bot removed the awaiting review label Feb 13, 2022

bedevere-bot added the awaiting changes label Feb 13, 2022

kumaraditya303 requested a review from asvetlov February 14, 2022 06:57

asvetlov approved these changes Feb 15, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting changes labels Feb 15, 2022

asvetlov merged commit 13c10bf into python:main Feb 15, 2022

kumaraditya303 deleted the asyncio-ssl branch March 4, 2022 13:55

AlexWaygood mentioned this pull request Mar 10, 2022

bpo-46198: Fix test_asyncio.test_sslproto #31801

Merged

kumaraditya303 mentioned this pull request May 31, 2022

Asyncio StreamReader fails to close Transport #78357

Closed

ambv mentioned this pull request Aug 3, 2022

test_asyncio: test_create_server_ssl_over_ssl() failed on ARM64 macOS 3.x #95573

Closed

tiran mentioned this pull request Aug 4, 2022

New asyncio ssl implementation is lacking license and origin information #95649

Closed

ambv added a commit to ambv/cpython that referenced this pull request Aug 4, 2022

Revert "bpo-44011: New asyncio ssl implementation (python#31275)"

07e6a8f

This reverts commit 13c10bf.

ambv mentioned this pull request Aug 4, 2022

[3.11] gh-88177: Revert the new asyncio.sslproto implementation #95663

Closed

This was referenced Sep 15, 2022

_SSLProtocolTransport.close() cannot close the connection until timeout or EOF MagicStack/uvloop#471

Open

(client) connections cannot be really closed before EOF with uvloop enabled aio-libs/aiohttp#6762

Closed

skshetry mentioned this pull request Jan 5, 2023

_prepare_credentials: connector fix for fsspec>=2022.12 treeverse/dvc-http#28

Merged

aloisklink mentioned this pull request Aug 1, 2023

gh-95649: Document that asyncio contains uvloop code #107536

Merged

bdraco mentioned this pull request Oct 31, 2023

Fix usage of proxy.py in test_proxy_functional aio-libs/aiohttp#7773

Merged

mjpieters mentioned this pull request Dec 16, 2023

asyncio.sslproto.SSLProtocol exception handling triggers TypeError: SSLProtocol._abort() takes 1 positional argument but 2 were given #113214

Closed

This was referenced Jan 14, 2024

[3.11] gh-95649: Document that asyncio contains uvloop code (GH-107536) #114045

Merged

[3.12] gh-95649: Document that asyncio contains uvloop code (GH-107536) #114046

Merged

Uh oh!

Uh oh!

Conversation

kumaraditya303 commented Feb 11, 2022 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kumaraditya303 commented Feb 11, 2022

Uh oh!

bedevere-bot commented Feb 11, 2022

Uh oh!

asvetlov commented Feb 11, 2022

Uh oh!

kumaraditya303 commented Feb 11, 2022

Uh oh!

bedevere-bot commented Feb 13, 2022

Uh oh!

asvetlov left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Feb 13, 2022

Uh oh!

kumaraditya303 commented Feb 14, 2022

Uh oh!

sobolevn commented Feb 14, 2022

Uh oh!

asvetlov commented Feb 14, 2022

Uh oh!

kumaraditya303 commented Feb 14, 2022

Uh oh!

asvetlov left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Feb 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kumaraditya303 commented Feb 11, 2022 •

edited by bedevere-bot

Loading