Repository navigation
gh-161222: Fix email.utils.encode_rfc2231() writing "None" as the charset - #161225
Open
andresdelfino wants to merge 1 commit into
Open
andresdelfino wants to merge 1 commit into
andresdelfino wants to merge 1 commit into
Conversation
…he charset When only *language* was given, the missing charset was interpolated into the result as the literal string "None". Leave the charset field blank instead, as RFC 2231 permits, mirroring how a missing language is already handled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
email.utils.encode_rfc2231()already replaces a missing language with an empty string, but not a missing charset. When only language was given,Noneended up in the output as the literal charset name:This also affected
Message.add_header()/set_param()when given a(None, language, value)tuple. This PR leaves the charset field blank in that case, which RFC 2231 section 4 permits. Output for every other combination of arguments is unchanged. (The(None, None)case, gh-85014, is not touched.)The new test covers both the direct call and the
add_header()path, and fails without the fix.🤖 Generated with Claude Code