-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
gh-156698: Fix _ProactorDatagramTransport never resumes a paused protocol after a write error
#156718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
graingert
wants to merge
8
commits into
python:main
Choose a base branch
from
graingert:fix-proactor-error-hang
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+145
−0
Open
gh-156698: Fix _ProactorDatagramTransport never resumes a paused protocol after a write error
#156718
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3006d6e
fix proactor error hang
graingert 60187dd
Merge branch 'main' into fix-proactor-error-hang
graingert d57cb23
fix DatagramTransport when errror_recieved calls sendto
graingert bb80478
Merge branch 'main' of github.com:python/cpython into fix-proactor-er…
graingert 37a9b5b
Update Lib/asyncio/proactor_events.py
graingert d8f9aae
Merge branch 'main' into fix-proactor-error-hang
graingert 9eda8d0
don't resume a closed transport
graingert 9fcd45c
Merge branch 'main' into fix-proactor-error-hang
graingert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
Misc/NEWS.d/next/Library/2026-08-31-00-00-00.gh-issue-156698.gyDxUe.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Fix :class:`asyncio.ProactorEventLoop` UDP transports so that a write | ||
| error no longer strands a paused protocol: the write loop is now | ||
| rescheduled when data remains buffered, and the protocol is resumed | ||
| when the buffer has drained. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kumaraditya303 this change doesn't make sense without the other changes from #156921
It would be easier if I could get that PR that fixes both issues reviewed in one go