gh-155418: Fix TaskGroup hang when a task cancels it before suspending - #155421
Conversation
| await asyncio.sleep(10) | ||
|
|
||
| async with asyncio.TaskGroup() as tg: | ||
| task = tg.create_task(child(tg)) |
There was a problem hiding this comment.
Maybe use your reproducer with the print as well? could be useful to catch (instead of print, just use a list and mutate it)
There was a problem hiding this comment.
thanks! just pushed the changes
| tg.cancel() | ||
| await asyncio.sleep(10) | ||
|
|
||
| async with asyncio.TaskGroup() as tg: |
There was a problem hiding this comment.
I thought the problem was with the eager task factory?
There was a problem hiding this comment.
hi! if i understand you well - BaseTestTaskGroup class that stores all of the tests is not inheriting from unittests TestCase https://github.com/deadlovelll/cpython/blob/62ab3f87bdb17aafa97e44fd26386893ead0497b/Lib/test/test_asyncio/test_taskgroups.py#L60.
Runners are TestTaskGroup and TestEagerTaskTaskGroup that inherits from BaseTestTaskGroup and unittest.IsolatedAsyncioTestCase, they are located at the bottom of the file https://github.com/deadlovelll/cpython/blob/62ab3f87bdb17aafa97e44fd26386893ead0497b/Lib/test/test_asyncio/test_taskgroups.py#L1307-L1315
TestEagerTaskTaskGroup already inject eager factory for this
| async def child(tg): | ||
| tg.cancel() | ||
| await asyncio.sleep(10) | ||
| done.append(True) |
There was a problem hiding this comment.
You can just do self.fail(<message>)
| @@ -0,0 +1,2 @@ | |||
| Fix :class:`asyncio.TaskGroup` hang when a task cancels it before | |||
There was a problem hiding this comment.
this should mention about eager task factory
There was a problem hiding this comment.
Thanks for the comments, I'll fix them during the day
There was a problem hiding this comment.
pushed the changes, take a look please
kumaraditya303
added
topic-asyncio
needs backport to 3.14
|
There are merge conflicts. |
|
Thanks @deadlovelll for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
Sorry, @deadlovelll and @kumaraditya303, I could not cleanly backport this to |
|
Sorry, @deadlovelll and @kumaraditya303, I could not cleanly backport this to |
|
ugh, @kumaraditya303 i'll create the bp, if you dont mind |
|
@kumaraditya303 there's no |
kumaraditya303
removed
needs backport to 3.14
3 participants
Fix TaskGroup hang when a task cancels it before suspending
For more details see gh-155418