gh-84943: Add support for 'directonly' and 'innocuous' flags for user-defined functions - #149961
Open
jbosboom wants to merge 1 commit into
Open
gh-84943: Add support for 'directonly' and 'innocuous' flags for user-defined functions#149961jbosboom wants to merge 1 commit into
jbosboom wants to merge 1 commit into
Conversation
Documentation build overview
268 files changed ·
|
jbosboom
force-pushed
the
sqlite-innocuous-directonly
branch
from
May 17, 2026 20:23
725a8cc to
9700f31
Compare
Contributor
Author
|
The CI job failed due to a DNS problem. The other sanitizer jobs succeeded, so I think it just needs to be re-run. |
|
This PR is stale because it has been open for 90 days with no activity. |
…r user-defined functions Co-authored-by: Erlend E. Aasland <erlend@python.org>
jbosboom
force-pushed
the
sqlite-innocuous-directonly
branch
from
August 19, 2026 20:08
9700f31 to
45b8215
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #20398, hence Co-authored-by. The flags have also been added to
create_window_function, which did not exist at the time.apply_deterministic_flag_if_supportedwas dropped because all stable Python versions require SQLite version 3.15.2 or later. The other two apply-flag-if-supported functions were modified to only raise when the flag is True. The tests were moved to their new location with updated style and some unnecessary SQL statements were dropped. The documentation now links to the SQLite documentation, which seems to be the prevailing style, rather than repeating it inline.