Skip to content

gh-106318: Add doctest role and a 'See also' item for str.split()#144367

Merged
StanFromIreland merged 1 commit into
python:mainfrom
adorilson:106318.split
Jun 4, 2026
Merged

gh-106318: Add doctest role and a 'See also' item for str.split()#144367
StanFromIreland merged 1 commit into
python:mainfrom
adorilson:106318.split

Conversation

@adorilson
Copy link
Copy Markdown
Contributor

@adorilson adorilson commented Jan 31, 2026 •
edited by github-actions Bot
Loading

WIP to #106318

#106318: Add doctest role and a 'See also' item for str.split()

📚 Documentation preview 📚: https://cpython-previews--144367.org.readthedocs.build/

@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news labels Jan 31, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Jan 31, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jan 31, 2026
Open
davidlowryduda
davidlowryduda reviewed Feb 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@davidlowryduda davidlowryduda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label May 5, 2026
@serhiy-storchaka serhiy-storchaka requested a review from hugovk June 2, 2026 18:32
@StanFromIreland
Copy link
Copy Markdown
Member

StanFromIreland commented Jun 3, 2026

Adding many doctests is a bit of a split topic: #111704 I think we would however avoid some churn if we ran them all by default.

@hugovk hugovk added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 4, 2026
@hugovk
Copy link
Copy Markdown
Member

hugovk commented Jun 4, 2026

I think we would however avoid some churn if we ran them all by default.

We should check how much longer that takes to run: #111704 (comment)

But also continue in that issue :)

@StanFromIreland StanFromIreland merged commit a96cba5 into python:main Jun 4, 2026
46 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Jun 4, 2026
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented Jun 4, 2026

Thanks @adorilson for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Jun 4, 2026

GH-150908 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 4, 2026
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Jun 4, 2026

GH-150909 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 4, 2026
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Jun 4, 2026

GH-150910 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 4, 2026
StanFromIreland pushed a commit that referenced this pull request Jun 4, 2026
@miss-islington @adorilson
[3.13] gh-106318: Add doctest role and a 'See also' to the `str.split…
d7beb9c 
…()` docs (GH-144367)

(cherry picked from commit a96cba5)

Co-authored-by: Adorilson Bezerra <adorilson@gmail.com>
StanFromIreland pushed a commit that referenced this pull request Jun 4, 2026
@miss-islington @adorilson
[3.14] gh-106318: Add doctest role and a 'See also' to the `str.split…
35ec255 
…()` docs (GH-144367)

(cherry picked from commit a96cba5)

Co-authored-by: Adorilson Bezerra <adorilson@gmail.com>
StanFromIreland pushed a commit that referenced this pull request Jun 4, 2026
@miss-islington @adorilson
[3.15] gh-106318: Add doctest role and a 'See also' to the `str.split…
253c518 
…()` docs (GH-144367)

(cherry picked from commit a96cba5)

Co-authored-by: Adorilson Bezerra <adorilson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

+1 more reviewer

@davidlowryduda davidlowryduda davidlowryduda left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news stale Stale PR or inactive for long period of time.

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@adorilson @StanFromIreland @hugovk @davidlowryduda @serhiy-storchaka