Skip to content

gh-119123: Fix sniffer to understand csv lists - #134219

Closed
aterrel wants to merge 6 commits into
python:mainfrom
aterrel:gh-119123
Closed

gh-119123: Fix sniffer to understand csv lists#134219
aterrel wants to merge 6 commits into
python:mainfrom
aterrel:gh-119123

Conversation

@aterrel

@aterrel aterrel commented May 19, 2025

Copy link
Copy Markdown

@python-cla-bot

python-cla-bot Bot commented May 19, 2025

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app

bedevere-app Bot commented May 19, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app

bedevere-app Bot commented May 19, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@aterrel

aterrel commented May 19, 2025

Copy link
Copy Markdown
Author

@bedevere-app I don't think this needs a news entry

@bedevere-app

bedevere-app Bot commented May 19, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app

bedevere-app Bot commented May 19, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app

bedevere-app Bot commented May 19, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@aterrel

aterrel commented May 20, 2025

Copy link
Copy Markdown
Author

@serhiy-storchaka can you review this PR, Thanks!

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 24, 2026
@serhiy-storchaka

Copy link
Copy Markdown
Member

Thank you, but I do not think that this is the right approach.

Removing [...] from the sample teaches the sniffer one particular data syntax, and leaves the underlying problem: a character adjacent to a quoted run was counted as evidence of a delimiter even when it does not delimit anything. On the main branch the sniffer was rewritten (gh-83273) and this code no longer exists; a fix for the maintenance branches should not depend on the format of the data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants