gh-85935: Check for nargs=0 for positional arguments in argparse#124839
Merged
serhiy-storchaka merged 4 commits intoOct 12, 2024
Conversation
Raise ValueError in add_argument() if either explicit nargs=0 or action that does not consume arguments (like 'store_const' or 'store_true') is specified for positional argument.
savannahostrowski
approved these changes
Oct 10, 2024
savannahostrowski
left a comment
savannahostrowski
left a comment
Member
There was a problem hiding this comment.
Overall, LGTM. I had one comment about whether we could be more actionable in the error message, but there may be existing style guidance around error messages that I don't know about, which makes my comment moot.
…wJUy.rst Co-authored-by: Savannah Ostrowski <savannahostrowski@gmail.com>
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
Author
There was a problem hiding this comment.
Thank you for your review @savannahostrowski. I think that the error messages are in line with existing error messages and do not need to be too verbose. This is a task for documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise ValueError in add_argument() if either explicit nargs=0 or action that does not consume arguments (like 'store_const' or 'store_true') is specified for positional argument.