Skip to content

gh-121671: Increase test coverage of ast.get_docstring - #121674

Merged
encukou merged 1 commit into
python:mainfrom
tomasr8:get-docstring
Jul 13, 2024
Merged

encukou merged 1 commit into
python:mainfrom
tomasr8:get-docstring

Conversation

@tomasr8

@tomasr8 tomasr8 commented Jul 13, 2024 •

Copy link
Copy Markdown
Member

Generated as: ./python ../coveragepy run --pylib --branch --source=ast Lib/test/regrtest.py test_ast
To get the HTML report: ./python ../coveragepy/ html -i --include=./Lib/* --omit="Lib/test/*,Lib/*/tests/*"

Before:
image

After:
image

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Good addition.

@encukou
encukou merged commit 0a26aa5 into python:main Jul 13, 2024
@encukou encukou added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Jul 13, 2024
@miss-islington-app

Copy link
Copy Markdown

Thanks @tomasr8 for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Thanks @tomasr8 for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 13, 2024
…nGH-121674)

Increase test coverage for `ast.get_docstring`
(cherry picked from commit 0a26aa5)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
@bedevere-app

bedevere-app Bot commented Jul 13, 2024

Copy link
Copy Markdown

GH-121690 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 13, 2024
…nGH-121674)

Increase test coverage for `ast.get_docstring`
(cherry picked from commit 0a26aa5)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jul 13, 2024
@bedevere-app

bedevere-app Bot commented Jul 13, 2024

Copy link
Copy Markdown

GH-121691 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 13, 2024
encukou pushed a commit that referenced this pull request Jul 13, 2024
…21674) (GH-121690)

(cherry picked from commit 0a26aa5)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
@tomasr8
tomasr8 deleted the get-docstring branch July 13, 2024 13:23
encukou pushed a commit that referenced this pull request Jul 13, 2024
…21674) (GH-121691)

(cherry picked from commit 0a26aa5)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
IljaManakov pushed a commit to IljaManakov/cpython that referenced this pull request Jul 13, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants