gh-121153: Change _PyLong_CompactValue() return type to int

[vstinner]

• Issue: Incorrect use of _PyLong_CompactValue() #121153

[vstinner]

cc @serhiy-storchaka @markshannon

[serhiy-storchaka]

This is incomplete change. You need also to change the code that calls _PyLong_CompactValue() (and simplify it).

[bedevere-app]

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

[vstinner]

You need also to change the code that calls _PyLong_CompactValue() (and simplify it).

Ok, I updated _PyLong_CompactValue() usage as well.

[vstinner]

@serhiy-storchaka: It would be nice if you could review this change since I'm not sure if it's correct.

[serhiy-storchaka]

You need to update also other code. Take #121154 and replace Py_ssize_t with int. Then remove dead code.

[serhiy-storchaka]

This code does not make sense.

[vstinner]

I don't understand this code.

[serhiy-storchaka]

This is an overflow check for i_result += b.

[vstinner]

You need to update also other code. Take #121154 and replace Py_ssize_t with int. Then remove dead code.

I'm not sure that I'm not the right person to implement this change. Maybe you should create your own PR and I abandon this PR.

[vstinner]

This PR changes PyUnstable_Long_CompactValue() return type. I documented that change.

If it's an issue, we can leave PyUnstable_Long_CompactValue() return type unchanged.

[serhiy-storchaka]

Yes, it needs also changing PyUnstable_Long_CompactValue which may be defined as an alias of _PyLong_CompactValue.

Technically, it now LGTM. But we should ask @markshannon what he thinks about changing the return type. Why it was Py_ssize_t at first place?

[vstinner]

#121154 was merged instead.