gh-119726: emit AArch64 trampolines in the data section - #121280
Merged
Merged
Conversation
Emit AArch64 trampolines in the data section (instead of the code) of the stencil. In many cases this allows the branch to the next micro-op at the end of the stencil to be replaced with a fall-through NOP.
4 of 5 tasks
Contributor
Author
|
@brandtbucher I have provided a news entry but I feel we can skip it for the PR. Let me know what you think. |
brandtbucher
added
performance
brandtbucher
approved these changes
Jul 3, 2024
brandtbucher
left a comment
brandtbucher
left a comment
Member
There was a problem hiding this comment.
Looks great! Just one minor comment:
| instruction &= 0xFC000000 | ||
| instruction |= ((base - hole.offset) >> 2) & 0x03FFFFFF | ||
| self.body[where] = instruction.to_bytes(4, sys.byteorder) | ||
| new_hole = hole.replace(addend=base, symbol=None, value=HoleValue.DATA) |
…e-119726.Fjv_Ab.rst Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit AArch64 trampolines in the data section (instead of the code) of the stencil. In many cases this allows the branch to the next micro-op at the end of the stencil to be replaced with a fall-through NOP.