gh-113932: assert SyntaxWarning in test_compile.TestSpecifics.test_…#113933
Merged
Conversation
….test_condition_expression_with_redundant_comparisons_compiles
Eclips4
added
skip news
and removed
tests
iritkatriel
reviewed
Jan 11, 2024
iritkatriel
left a comment
iritkatriel
left a comment
Member
There was a problem hiding this comment.
Did you try running this test with -We ? Does the assertion still work?
Member
|
My point is: the title of the PR says 'suppress warning', but the PR actually does more - it asserts the warning. |
Member
Author
Yes, it's works.
How's about "Make test_x more accurate"? |
iritkatriel
changed the title
SyntaxWarning in test_compile.TestSpecifics.test_…SyntaxWarning in test_compile.TestSpecifics.test_…
iritkatriel
approved these changes
Jan 11, 2024
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…condition_expression_with_redundant_comparisons_compiles
test_compileraises aSyntaxWarning#113932