Repository navigation
gh-102213: Optimize the performance of __getattr__ - #103761
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the logically corrected version of GH-102248.
GH-102248 caused several issues and had been reverted. This PR (I think) correctly implements it.
Tests passed on Ubuntu 22.04 (WSL) gcc-11 with
--pydebug.I also do the perf tests in the original PR, (
--enable-optimizationswith my AMD 5900X)Before,
After,
cc: @Fidget-Spinner