Skip to content

sqlite3: Connection.create_collation() documentation inaccuracies #92780

Description

@AdrianIssott

Documentation

Currently the documentation of sqlite3.create_collation() (https://docs.python.org/3/library/sqlite3.html#sqlite3.Connection.create_collation) says:

Note that the callable will get its parameters as Python bytestrings, which will normally be encoded in UTF-8.

However, as you can see from the discussion on #92742 that's incorrect in python 3 and the callable gets its parameters as Python strs which matches the SQLite docs which says:

Collating functions only matter when comparing string values

Activity

  1. changed the title [-]The documentation of sqlite3.create_collation() should say the callable gets its parameters as strings[/-] [+]sqlite3: `Connection.create_collation()` documentation inaccuracies[/+] on May 13, 2022
  2. added a commit that references this issue on May 13, 2022
  3. erlend-aasland commented on May 16, 2022

    @erlend-aasland
    Contributor

    Would you mind reviewing the proposed change, @AdrianIssott?

  4. added a commit that references this issue on May 18, 2022
  5. added 3 commits that reference this issue on May 18, 2022
  6. added 2 commits that reference this issue on May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions