clinic: add option to pass module object to converter function #86570

Activity

1. tiran commented on Nov 19, 2020

   

   tiran

   on Nov 19, 2020

   Last edited by erlend-aasland

   MemberAuthor

   More actions

   Sometimes the converter function for CConverter must access the current module object in order to access the current module state. Currently CConverter subclasses have no easy way to pass the module to the converter function. It would be fantastic if easier CConverter would get an option to pass the module.

   Example:

   #23398 converts the struct module to multiphase initialization. The struct module has a converter for cached struct definitions. The cache used to be a module level object. It is now an interpreter scoped object. I used a custom parse_arg() function to pass the module object:

   class cache_struct_converter(CConverter):
       type = 'PyStructObject *'
       converter = 'cache_struct_converter'
       c_default = "NULL"

       def parse_arg(self, argname, displayname):
           return """
               if (!{converter}(module, {argname}, &{paramname})) {{{{
                   goto exit;
               }}}}
               """.format(argname=argname, paramname=self.name,
                          converter=self.converter)

       def cleanup(self):
           return "Py_XDECREF(%s);\n" % self.name
2. tiran

   added

   3.10 (EOL)end of lifeend of life

   topic-argument-clinic

   type-featureA feature request or enhancementA feature request or enhancement

   on Nov 19, 2020
3. ezio-melotti

   transferred this issue fromon Apr 10, 2022
4. erlend-aasland

   added

   3.13only security fixesonly security fixes

   and removed

   3.10 (EOL)end of lifeend of life

   on Jan 4, 2024