Repository navigation
Use specs instead of just __loader__ in C code #86298
Description
| BPO | 42132 |
|---|---|
| Nosy | @brettcannon, @corona10 |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = None
created_at = <Date 2020-10-23.22:16:01.448>
labels = ['interpreter-core', 'type-bug', '3.10']
title = 'Use specs instead of just __loader__ in C code'
updated_at = <Date 2020-10-24.16:28:23.690>
user = 'https://github.com/brettcannon'bugs.python.org fields:
activity = <Date 2020-10-24.16:28:23.690>
actor = 'corona10'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Interpreter Core']
creation = <Date 2020-10-23.22:16:01.448>
creator = 'brett.cannon'
dependencies = []
files = []
hgrepos = []
issue_num = 42132
keywords = []
message_count = 1.0
messages = ['379483']
nosy_count = 2.0
nosy_names = ['brett.cannon', 'corona10']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue42132'
versions = ['Python 3.10']
Activity
brettcannon commentedon Oct 23, 2020
_warnings.c, pylifecycle.c, and pythonrun.c all either use or set
__loader__but without also falling back on__spec__.warsaw commentedon Oct 3, 2022
I'm going to take a look at these module attribute issues during the 2022 core sprint.
warsaw commentedon Oct 4, 2022
I have
_warnings.cimplemented and tested.warsaw commentedon Oct 4, 2022
I think there's nothing to do for
pythonrun.c. These set__loader__but not__spec__directly, and the documentation outlines the expected semantics. If the documented semantics are incorrect, then there should be a separate tracking bug for that case.Looking at
pylifecycle.cnext.7 remaining items
PoC for checking both __loader__ and __spec__.loader
pythongh-122191: Fix test_warnings failure if run with -Werror
pythongh-86298: Add black box tests in test_warnings
serhiy-storchaka commentedon Jul 25, 2024
These warnings are only emitted for the C implementation. See #122255.
gh-122191: Fix test_warnings failure if run with -Werror (GH-122222)
pythongh-122191: Fix test_warnings failure if run with -Werror (pytho…
[3.12] pythongh-122191: Fix test_warnings failure if run with -Werror (…
[3.12] gh-122191: Fix test_warnings failure if run with -Werror (GH-1…
[3.13] gh-122191: Fix test_warnings failure if run with -Werror (GH-1…
gh-122255: Add black box tests in test_warnings (GH-122227)
pythongh-122255: Add black box tests in test_warnings (pythonGH-122227)
pythongh-122255: Add black box tests in test_warnings (pythonGH-122227)
[3.13] gh-122255: Add black box tests in test_warnings (GH-122227) (G…
[3.12] gh-122255: Add black box tests in test_warnings (GH-122227) (G…
pythongh-122255: Add black box tests in test_warnings (pythonGH-122227)