tarfile.extractall fails to overwrite symlinks

[FredericBeister]

BPO	31808
Nosy	@serhiy-storchaka, @corona10

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2017-10-18.08:29:35.565>
labels = ['3.7', 'type-bug', 'library']
title = 'tarfile.extractall fails to overwrite symlinks'
updated_at = <Date 2017-11-19.10:10:23.383>
user = 'https://bugs.python.org/FredericBeister'

bugs.python.org fields:

activity = <Date 2017-11-19.10:10:23.383>
actor = 'corona10'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2017-10-18.08:29:35.565>
creator = 'Frederic Beister'
dependencies = []
files = []
hgrepos = []
issue_num = 31808
keywords = ['patch']
message_count = 2.0
messages = ['304563', '306348']
nosy_count = 3.0
nosy_names = ['serhiy.storchaka', 'corona10', 'Frederic Beister']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue31808'
versions = ['Python 3.6', 'Python 3.7']

Linked PRs

• gh-75989: TarFile.extractall and TarFile.extract now overwrite symlinks when extracting hardlinks #137316
• [3.14] gh-75989: TarFile.extractall and TarFile.extract now overwrite symlinks when extracting hardlinks (GH-137316) #139705
• [3.13] gh-75989: TarFile.extractall and TarFile.extract now overwrite symlinks when extracting hardlinks (GH-137316) #139771

[FredericBeister]

The fix for https://bugs.python.org/issue10761 somehow didn't make it into 3.5 and later - I have the same behavior as described there in 3.5.1 and 3.6.1 (tested on Ubuntu 16.04)

[corona10]

I 've submitted the patch please take a look.

[aeurielesn]

I confirmed that part of the reported issue has been fixed for symlinks in #21409.
However, I could confirm the same issue happens for hardlinks as well. I have opened a PR to address this corner case.

[encukou]

Thanks for the fix!
The backport should go to 3.14.1, so I'll keep the issue open.