selectors and modify()

[ArnaudFaure]

BPO	19497
Nosy	@gvanrossum
Files	modify_data.patch: Add a shortcut to BaseSelector.modify when update data modify_data.2.patch: patch cpython default branch modify_data.3.patch modify_data_use_a_shortcut.patch: Add a shortcut to BaseSelector.modify when update data

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/gvanrossum'
closed_at = <Date 2013-11-07.17:13:54.955>
created_at = <Date 2013-11-04.20:40:21.321>
labels = ['type-feature']
title = 'selectors and modify()'
updated_at = <Date 2013-11-07.17:13:54.954>
user = 'https://bugs.python.org/ArnaudFaure'

bugs.python.org fields:

activity = <Date 2013-11-07.17:13:54.954>
actor = 'gvanrossum'
assignee = 'gvanrossum'
closed = True
closed_date = <Date 2013-11-07.17:13:54.955>
closer = 'gvanrossum'
components = []
creation = <Date 2013-11-04.20:40:21.321>
creator = 'Arnaud.Faure'
dependencies = []
files = ['32499', '32503', '32504', '32512']
hgrepos = []
issue_num = 19497
keywords = ['patch']
message_count = 6.0
messages = ['202172', '202176', '202177', '202180', '202249', '202369']
nosy_count = 3.0
nosy_names = ['gvanrossum', 'neologix', 'Arnaud.Faure']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue19497'
versions = ['Python 3.4']

[gvanrossum]

The patch doesn't actually apply, not just because the pathnames are different, but because the unittests in Lib/test/test_selectors.py have a different structure.

[ArnaudFaure]

Didn't thaught about that :( ....
Did my way throught the developper tutorial, got the default cpython repo, did the modif, run patchcheck then the tests with ./python -m test -j3.
Thanks for your patience ;)

[gvanrossum]

Check out my review: http://bugs.python.org/review/19497/#ps9821

[ArnaudFaure]

patch updated

[ArnaudFaure]

Corrected and cleaned

[gvanrossum]

Fixed by revision 9c976f1b17e9.