Skip to content

Use implemenation-specific I/O open / constructors in tests #133982

Closed
Closed
Use implemenation-specific I/O open / constructors in tests#133982
Labels
testsTests in the Lib/test dirtopic-IOtype-bugAn unexpected behavior, bug, or error

Description

@cmaloney
cmaloney
opened on May 13, 2025

Bug report

Bug description:

Most I/O tests are setup for running on multiple implementations. As tests have been added for bug fixes some now use open() or the class constructor directly instead of the self. version which does implementation delegation. This means that some features are not tested when the I/O module implementation is changed (ex. _io, _pyio).

I'm planning to use this as a meta issue as I find individual cases and update the test, fixing up implementations as needed to get tests passing.

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs

Activity

  1. cmaloney
    added
    type-bugAn unexpected behavior, bug, or error
    on May 13, 2025
  2. cmaloney
    added a commit that references this issue on May 13, 2025

    pythongh-133982: Update test_bufio to use self.open

    4f692d5
  3. ZeroIntensity
    added
    testsTests in the Lib/test dir
    on May 14, 2025
  4. picnixz
    added
    topic-IO
    on May 15, 2025
  5. cmaloney
    added 2 commits that reference this issue on May 18, 2025

    pythongh-133982: Run unclosed file test on all io implementations

    5d24e46

    pythongh-133982: Run unclosed file test on all io implementations

    cd3b196
  6. ambv
    added a commit that references this issue on May 21, 2025

    gh-133982: Update test_bufio to use self.open (gh-133983)

    84d5f8d
  7. miss-islington
    added 2 commits that reference this issue on May 21, 2025

    pythongh-133982: Update test_bufio to use self.open (pythongh-133983)

    09ab621

    pythongh-133982: Update test_bufio to use self.open (pythongh-133983)

    f20976d
  8. ambv
    added a commit that references this issue on May 21, 2025

    gh-133982: Run unclosed file test on all io implementations (gh-134165)

    5b0e827
  9. miss-islington
    added 2 commits that reference this issue on May 21, 2025

    pythongh-133982: Run unclosed file test on all io implementations (py…

    0b27e08

    pythongh-133982: Run unclosed file test on all io implementations (py…

    4f82e8d
  10. ambv
    added 3 commits that reference this issue on May 21, 2025

    [3.14] gh-133982: Update test_bufio to use self.open (gh-133983) (gh-…

    c612a4d

    [3.13] gh-133982: Update test_bufio to use self.open (gh-133983) (gh-…

    de6d199

    [3.14] gh-133982: Run unclosed file test on all io implementations (g…

    fade04e

  11. 18 remaining items

  12. Pranjal095
    added a commit that references this issue on Jul 12, 2025

    pythongh-133982: Test _pyio.BytesIO in free-threaded tests (pythongh-…

    4078eb8
  13. picnixz
    added 2 commits that reference this issue on Jul 13, 2025

    pythongh-133982: Use implementation-specific `open` in `test_fileio.O…

    cfdfb4c

    pythongh-133982: Test _pyio.BytesIO in free-threaded tests (pythongh-…

    1c153fb
  14. taegyunkim
    added 4 commits that reference this issue on Aug 4, 2025

    pythongh-133982: Update test_bufio to use self.open (pythongh-133983)

    7777f42

    pythongh-133982: Run unclosed file test on all io implementations (py…

    87d8510

    pythongh-133982: Use implementation-specific `open` in `test_fileio.O…

    37f8ef7

    pythongh-133982: Test _pyio.BytesIO in free-threaded tests (pythongh-…

    78f3d3b
  15. Agent-Hellboy
    added 2 commits that reference this issue on Aug 19, 2025

    pythongh-133982: Use implementation-specific `open` in `test_fileio.O…

    f7e14ae

    pythongh-133982: Test _pyio.BytesIO in free-threaded tests (pythongh-…

    8bb2524
  16. cmaloney
    added 2 commits that reference this issue on Sep 2, 2025

    pythongh-133982: Refer to implementation specific mocks

    751788f

    pythongh-133982: Refer to implementation specific mocks

    2fa3eff

  17. cmaloney commented on Nov 7, 2025

    @cmaloney
    cmaloney
    on Nov 7, 2025
    ContributorAuthor

    Closing, I think these are all fixed. test_largefile the one instance is in TestSocketSendfile which is _io only.

  18. cmaloney
    closed this as completedon Nov 7, 2025
  19. gostak-dd
    added 2 commits that reference this issue on Jun 2, 2026

    pythongh-133982: Update test_bufio to use self.open (pythongh-133983)

    b4761cf

    pythongh-133982: Run unclosed file test on all io implementations (py…

    3d0011e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testsTests in the Lib/test dirtopic-IOtype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions