Skip to content

Update bundled setupotools in test.wheeldata and remove wheel.whl #132415

Closed
Closed
Update bundled setupotools in test.wheeldata and remove wheel.whl#132415
Labels
dependenciesPull requests that update a dependency fileinfraCI, GitHub Actions, buildbots, Dependabot, etc.type-bugAn unexpected behavior, bug, or error

Description

@stefanor
stefanor
opened on Apr 11, 2025

Bug report

Bug description:

test.wheeldata includes bundled setuptools and wheel wheels to build packages. Since setuptools>=0.70.1, the bdist_wheel method is natively included in setuptools, and there's no necessity to have the wheel library available, to build wheels any more.

Relatedly, wheel>=0.46.0 de-vendored the packaging library, so current versions of wheel can't be used without having packaging available too.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs

Activity

  1. stefanor
    added
    type-bugAn unexpected behavior, bug, or error
    on Apr 11, 2025
  2. picnixz
    added
    dependenciesPull requests that update a dependency file
    infraCI, GitHub Actions, buildbots, Dependabot, etc.
    on Apr 11, 2025

  3. AA-Turner commented on Apr 11, 2025

    @AA-Turner
    AA-Turner
    on Apr 11, 2025
    Member

    Do tests fail with different versions of wheel installed? I'm trying to work out if this is just a cosmetic change.

  4. stefanor commented on Apr 12, 2025

    @stefanor
    stefanor
    on Apr 12, 2025
    ContributorAuthor

    With the new setuptools, wheel isn't used any more, so bumping it or not makes no difference.

  5. AA-Turner
    marked Update setupotools.whl to 70.1+, drop wheel.whl #132866 as a duplicate of this issue on Apr 24, 2025

  6. AA-Turner commented on Apr 24, 2025

    @AA-Turner
    AA-Turner
    on Apr 24, 2025
    Member

    Adding/updating binary artefacts increases the repository size, with little observable/user benefit in this case (a test file). It might be easier just to do the update though, we will probably see more 'update' PRs (such as @hroncok's #132867, which I imagine was inadvertant -- it took me a couple of minutes to find this issue again).

    A

  7. AA-Turner
    changed the title [-]Setuptools now includes bdist_wheel[/-] [+]Update bundled setupotools in `test.wheeldata` and remove `wheel.whl`[/+] on Apr 24, 2025

  8. hroncok commented on Apr 24, 2025

    @hroncok
    hroncok
    on Apr 24, 2025
    Contributor

    Sorry for the duplicate issue and PR. I did not find this one.

    Here is my rationale from #132866

    In Fedora, we use our own setuptools and wheel wheels from WHEEL_PKG_DIR to test Python.

    wheel 0.45+ now depends on packaging pypa/wheel#655

    Since we would like to update our wheel and we already updated setuptools to a version that does not require wheel to create wheels, I was wondering whether we could update setuptools in https://github.com/python/cpython/tree/main/Lib/test/wheeldata to 70.1+ and drop the wheel.whl. That would make it easier for us to update.

  9. AA-Turner commented on Apr 24, 2025

    @AA-Turner
    AA-Turner
    on Apr 24, 2025
    Member

    Ok. I've opened a new PR, as wheeldata isn't covered by the ensurepip tooling, and also to use a newer release. See #132887.

    A

  10. AA-Turner
    added a commit that references this issue on Apr 24, 2025

    gh-132415: Update vendored setuptools in ``Lib/test/wheeldata`` (#132887

    c9f3f5b
  11. AA-Turner
    closed this as completedon Apr 24, 2025

  12. hroncok commented on Apr 25, 2025

    @hroncok
    hroncok
    on Apr 25, 2025
    Contributor

    Thanks

  13. hroncok
    added a commit that references this issue on Apr 25, 2025

    00666: pythongh-132415: Update vendored setuptools in ``Lib/test/whee…

    d3755e0
  14. hugovk
    added a commit that references this issue on Apr 25, 2025

    Revert "pythongh-132415: Update vendored setuptools in ``Lib/test/whe…

    b404002

  15. 14 remaining items

  16. miss-islington
    added a commit that references this issue on Jun 11, 2025

    pythongh-132415: Use shutil.which() in missing_compiler_executable() (p…

    80adfa6
  17. Yhg1s
    added a commit that references this issue on Jun 11, 2025

    [3.13] gh-132415: Update vendored setuptools in ``Lib/test/wheeldata`` (

    5f5b173
  18. ambv
    added 3 commits that reference this issue on Jun 11, 2025

    [3.12] gh-132415: Use shutil.which() in missing_compiler_executable() (…

    d43cb4f

    [3.12] pythongh-132415: Update vendored setuptools in ``Lib/test/whee…

    c69b25b

    [3.12] gh-132415: Update vendored setuptools in ``Lib/test/wheeldata` (…

    033aa5c
  19. stratakis
    added a commit that references this issue on Jun 12, 2025

    00460: pythongh-132415: Update vendored setuptools in ``Lib/test/whee…

    467772f
  20. hroncok
    added a commit that references this issue on Jun 12, 2025

    00460: pythongh-132415: Update vendored setuptools in ``Lib/test/whee…

    c5f0853
  21. past-hypothesis
    added a commit that references this issue on Jul 14, 2025

    [3.13] pythongh-132415: Update vendored setuptools in ``Lib/test/whee…

    1382caa
  22. befeleme
    added a commit that references this issue on Oct 10, 2025

    00460: pythongh-132415: Update vendored setuptools in ``Lib/test/whee…

    46bb3c5
  23. hrnciar
    added a commit that references this issue on Mar 3, 2026

    00460: pythongh-132415: Update vendored setuptools in ``Lib/test/whee…

    e320aa6
  24. hroncok
    added a commit that references this issue on Mar 26, 2026

    00460: pythongh-132415: Update vendored setuptools in ``Lib/test/whee…

    98f5001
  25. befeleme
    added a commit that references this issue on Aug 18, 2026

    00460: pythongh-132415: Update vendored setuptools in ``Lib/test/whee…

    8c58071
  26. hrnciar
    added a commit that references this issue on Oct 1, 2026

    00460: pythongh-132415: Update vendored setuptools in ``Lib/test/whee…

    696823e
  27. hroncok
    added 2 commits that reference this issue on Oct 1, 2026

    00460: pythongh-132415: Update vendored setuptools in ``Lib/test/whee…

    aa4c84e

    00460: pythongh-132415: Update vendored setuptools in ``Lib/test/whee…

    6fc6921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dependenciesPull requests that update a dependency fileinfraCI, GitHub Actions, buildbots, Dependabot, etc.type-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions