Skip to content

PyREPL raises exception while trying to write to the history file on a read-only file system #128066

Closed
Closed
PyREPL raises exception while trying to write to the history file on a read-only file system#128066
Labels
3.13only security fixes3.14bugs and security fixestopic-replRelated to the interactive shelltype-bugAn unexpected behavior, bug, or error

Description

@vladimir-poghosyan
vladimir-poghosyan
opened on Dec 18, 2024

Bug report

Bug description:

When using new Python 3.13 pyrepl on a read-only file system, attempting to exit the REPL raises the following exception: OSError: [Errno 30] Read-only file system: '/root/.python_history'. The same setup works with Python 3.12.

dev:/home/dev$ docker run -it --read-only python:3.12-slim-bookworm python3
Python 3.12.7 (main, Nov 12 2024, 02:26:49) [GCC 12.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> print('hello')
hello
>>> exit()
dev:/home/dev$ docker run -it --read-only python:3.13-slim-bookworm python3
Python 3.13.1 (main, Dec  4 2024, 20:40:24) [GCC 12.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> print('hello')
hello
>>> exit()
Exception ignored in atexit callback <function register_readline.<locals>.write_history at 0x7f56689a3600>:
Traceback (most recent call last):
  File "<frozen site>", line 574, in write_history
  File "/usr/local/lib/python3.13/_pyrepl/readline.py", line 453, in write_history_file
    f = open(os.path.expanduser(filename), "w",
OSError: [Errno 30] Read-only file system: '/root/.python_history'

CPython versions tested on:

3.12, 3.13

Operating systems tested on:

Linux

Linked PRs

Activity

  1. vladimir-poghosyan
    added
    type-bugAn unexpected behavior, bug, or error
    on Dec 18, 2024
  2. tomasr8
    added
    topic-replRelated to the interactive shell
    on Dec 18, 2024
  3. ZeroIntensity
    added
    3.13only security fixes
    3.14bugs and security fixes
    on Dec 18, 2024

  4. ZeroIntensity commented on Dec 18, 2024

    @ZeroIntensity
    ZeroIntensity
    on Dec 18, 2024
    Member

    I think the easiest fix would be to catch OSErrors there, and just log a warning if something goes wrong.

  5. skirpichev commented on Dec 20, 2024

    @skirpichev
    skirpichev
    on Dec 20, 2024
    Member

    It's silly that we get this error only at the end of session.

    Rather than catch OSError, maybe we should map EROFS errno to PermissionError on Linux. (Call to write_history_file() is wrapped with except (FileNotFoundError, PermissionError).)

  6. skirpichev
    added a commit that references this issue on Apr 11, 2025

    Prevent issues like python#128066

    3db477a

  7. feoh commented on May 20, 2025

    @feoh
    feoh
    on May 20, 2025
    Contributor

    Fix in hand. Tested locally by stealing the official Python image build dockerfile but using my own modified tarball with the fix.

    ╭─cpatti at rocinante in ~/src/personal 25-05-20 - 14:18:58
╰─○ docker run -it --read-only pyrepl_tst python3                       <region:us-east-1>
zsh: correct 'python3' to 'python' [nyae]? n
Python 3.15.0a0 (heads/cpatti_issue_128066-dirty:01225ff4a74, May 20 2025, 18:17:11) [GCC 12.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> print("Hellorld!")
Hellorld!
>>>
  8. ambv
    added a commit that references this issue on May 20, 2025

    gh-128066: Properly handle history file writes for RO fs on PyREPL (g…

    c91ad5d
  9. miss-islington
    added a commit that references this issue on May 20, 2025

    pythongh-128066: Properly handle history file writes for RO fs on PyR…

    4c7726f
  10. ambv
    added 3 commits that reference this issue on May 20, 2025

    [3.13] pythongh-128066: Properly handle history file writes for RO fs…

    d6a3cdc

    [3.14] gh-128066: Properly handle history file writes for RO fs on Py…

    379805d

    [3.13] gh-128066: Properly handle history file writes for RO fs on Py…

    b41e7b1
  11. ambv
    closed this as completedon May 20, 2025
  12. lkollar
    added a commit that references this issue on May 26, 2025

    pythongh-128066: Properly handle history file writes for RO fs on PyR…

    d251f8d
  13. Pranjal095
    added a commit that references this issue on Jul 12, 2025

    pythongh-128066: Properly handle history file writes for RO fs on PyR…

    aa0f8bf
  14. taegyunkim
    added a commit that references this issue on Aug 4, 2025

    pythongh-128066: Properly handle history file writes for RO fs on PyR…

    3fbcbbe
  15. gostak-dd
    added a commit that references this issue on Jun 2, 2026

    pythongh-128066: Properly handle history file writes for RO fs on PyR…

    b3e8060
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.13only security fixes3.14bugs and security fixestopic-replRelated to the interactive shelltype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions