Skip to content

PEP 737 implementation errors #117642

Closed
Closed
PEP 737 implementation errors#117642
Labels
3.13only security fixestopic-C-APItype-bugAn unexpected behavior, bug, or error

Description

@serhiy-storchaka
serhiy-storchaka
opened on Apr 8, 2024

Bug report

For some reasons gh-111696 implemented %T# and %N# instead of %#T and %#N. It does not only contradict PEP 737, but does not match the general principles of prinf-like format, and can cause problems in future.

Tests, which were added in gh-111696, were removed in gh-116417, so now this feature is not tested.

Linked PRs

Activity

  1. serhiy-storchaka
    added
    type-bugAn unexpected behavior, bug, or error
    topic-C-API
    3.13only security fixes
    on Apr 8, 2024
  2. serhiy-storchaka
    added 2 commits that reference this issue on Apr 8, 2024

    pythongh-117642: Fix PEP 737 implementation

    5d7cc9c

    gh-117642: Fix PEP 737 implementation (GH-117643)

    24a2bd0

  3. vstinner commented on Apr 8, 2024

    @vstinner
    vstinner
    on Apr 8, 2024
    Member

    I suppose that the issue can now be closed? Or did you spot other implementation issues?

  4. serhiy-storchaka commented on Apr 8, 2024

    @serhiy-storchaka
    serhiy-storchaka
    on Apr 8, 2024
    MemberAuthor

    Nothing more. I noticed a weird handling of # and when tried to update the tests, did not found them at place.

  5. serhiy-storchaka
    closed this as completedon Apr 8, 2024

  6. vstinner commented on Apr 8, 2024

    @vstinner
    vstinner
    on Apr 8, 2024
    Member

    Thanks for the fix.

  7. diegorusso
    added a commit that references this issue on Apr 17, 2024

    pythongh-117642: Fix PEP 737 implementation (pythonGH-117643)

    7bfeb8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.13only security fixestopic-C-APItype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions