Skip to content

Argument Clinic silently allow empty custom C basenames #107972

Closed
Closed
Argument Clinic silently allow empty custom C basenames#107972
Labels
topic-argument-clinictype-bugAn unexpected behavior, bug, or error

Description

@erlend-aasland
erlend-aasland
opened on Aug 15, 2023

See #107964 (comment):

Here's a very contrived example that silently passes on this PR, current main and on 3.12:

/*[clinic input]
output everything block
class C "void *" ""
# Trailing whitespace on following line!!!
C.meth as   
[clinic start generated code]*/

Linked PRs

Activity

  1. erlend-aasland
    added
    topic-argument-clinic
    on Aug 15, 2023

  2. erlend-aasland commented on Aug 15, 2023

    @erlend-aasland
    erlend-aasland
    on Aug 15, 2023
    ContributorAuthor

    We should fail() with something like "No C basename provided after 'as' keyword" in this case.

  3. AlexWaygood
    added
    type-bugAn unexpected behavior, bug, or error
    on Aug 15, 2023
  4. erlend-aasland
    added 2 commits that reference this issue on Aug 15, 2023

    pythongh-107972: Argument Clinic: Ensure a C basename is provided aft…

    376fd15

    gh-107972: Argument Clinic: Ensure a C basename is provided after 'as' (

    607f18c
  5. erlend-aasland
    closed this as completedon Aug 15, 2023
  6. iritkatriel
    added a commit that references this issue on Aug 16, 2023

    pythongh-107972: Argument Clinic: Ensure a C basename is provided aft…

    60de9ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    topic-argument-clinictype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions