Skip to content

ntpath.join() adds slash to incomplete UNC drive with trailing slash #103220

Closed
Closed
ntpath.join() adds slash to incomplete UNC drive with trailing slash#103220
Labels
3.10 (EOL)end of life3.11only security fixes3.12only security fixesOS-windowstype-bugAn unexpected behavior, bug, or error

Description

@barneygale
barneygale
opened on Apr 3, 2023

ntpath.join() incorrectly inserts an additional slash when joining an argument onto an incomplete UNC drive with a trailing slash:

>>> import ntpath
>>> ntpath.join('\\\\server\\share\\foo\\', 'bar')
'\\\\server\\share\\foo\\bar'  # ok
>>> ntpath.join('\\\\server\\share\\', 'foo')
'\\\\server\\share\\foo'  # ok
>>> ntpath.join('\\\\server\\', 'share')
'\\\\server\\\\share'  # wrong!
>>> ntpath.join('\\\\', 'server')
'\\\\\\server'  # wrong!

Before 005e694 (3.12), the last test case succeeds because splitdrive() doesn't identify '\\\\' as a UNC drive. But the third test case is reproducible going back to 3.11 and 3.10.

Linked PRs

Activity

  1. barneygale
    added
    type-bugAn unexpected behavior, bug, or error
    OS-windows
    3.11only security fixes
    3.10 (EOL)end of life
    3.12only security fixes
    on Apr 3, 2023
  2. barneygale
    added a commit that references this issue on Apr 3, 2023

    pythonGH-103220: Fix `ntpath.join()` of partial UNC drive with traili…

    6cdcb83

  3. eryksun commented on Apr 3, 2023

    @eryksun
    eryksun
    on Apr 3, 2023
    Contributor

    This would be an enhancement to add the ability to reliably join segments as a UNC drive. I don't think it has to be backported to 3.11 and 3.10.

  4. barneygale
    added a commit that references this issue on Apr 11, 2023

    GH-103220: Fix `ntpath.join()` of partial UNC drive with trailing sla…

    b57105a

  5. barneygale commented on Apr 11, 2023

    @barneygale
    barneygale
    on Apr 11, 2023
    ContributorAuthor

    Resolved in b57105a / #103221.

  6. barneygale
    closed this as completedon Apr 11, 2023
  7. warsaw
    added a commit that references this issue on Apr 11, 2023

    pythonGH-103220: Fix `ntpath.join()` of partial UNC drive with traili…

    0878460
  8. aisk
    added a commit that references this issue on Apr 18, 2023

    pythonGH-103220: Fix `ntpath.join()` of partial UNC drive with traili…

    7ea255d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.10 (EOL)end of life3.11only security fixes3.12only security fixesOS-windowstype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions