Fix TopoJson rendering for single-geometry objects - #2258
Closed
adarshsm wants to merge 1 commit into
Closed
Conversation
A TopoJSON object may be a single geometry (Polygon, MultiPolygon, ...) rather than a GeometryCollection. Single geometries have no "geometries" key, so TopoJson.style_data() raised KeyError: 'geometries' and the map failed to render. Style the object itself in that case. Closes python-visualization#1816
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1816.
The bug
A TopoJSON object can be either a
GeometryCollection(which has ageometrieslist) or a single geometry —Polygon,MultiPolygon,LineString, etc. — which has nogeometrieskey and is itself the feature.TopoJson.style_data()assumed the former and didresolved_object["geometries"]unconditionally, so any single-geometry object crashed on render:Minimal reproducer (from the issue, trimmed):
The fix
Branch on the object's
type: iterategeometriesfor aGeometryCollection(unchanged), otherwise treat the object itself as the single feature to style. The JS side (topojson.feature) already handles both shapes, so only the Python styling pass needed the guard.Tests
Added
test_topo_json_single_geometry, which renders a single-PolygonTopoJSON and asserts thestyle_functionis applied to the geometry. It fails withKeyErroronmainand passes with this change; the existingGeometryCollectionpath is unchanged and still covered.