Recognize match pattern captures as assignments - #865
Open
yangfan-yf-yf wants to merge 1 commit into
Open
Conversation
yangfan-yf-yf
marked this pull request as ready for review
August 26, 2026 11:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pattern capture names on
MatchAs,MatchStar, andMatchMappingare string fields, so the scope visitor did not register them as assignments. Rename consequently rejected those names as unresolved. Inline could also replace a capture with a value pattern, changing program semantics.This registers the three capture forms in their enclosing scope, returns a conservative unknown inference result for pattern assignments, and rejects inline whenever the selected name has a pattern-capture assignment. Rename now updates both capture definitions and references.
Fixes #861
Checklist
CHANGELOG.mdValidation
git diff origin/master...HEAD --checkpasses