PR: (Experimental) Replace Abstract class with PyObject.is_base_* methods#681
Closed
edreamleo wants to merge 37 commits intopython-rope:masterfrom
edreamleo:ekr-predicates2
Closed
PR: (Experimental) Replace Abstract class with PyObject.is_base_* methods#681edreamleo wants to merge 37 commits intopython-rope:masterfrom edreamleo:ekr-predicates2
edreamleo wants to merge 37 commits intopython-rope:masterfrom
edreamleo:ekr-predicates2
Conversation
…rk-rope2 into ekr-predicates2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on PR #664 (branch ekr-abstract-predicates, rev c88d487).
This PR replaces the three
Abstractclasses with corresponding predicate methods of thePyObjectclasses.This experimental PR fails many unit tests at present.
One would think this approach would work. We shall see.