PR: Remove a do-nothing statement in soi._handle_first_parameter#680
Merged
lieryan merged 1 commit intopython-rope:masterfrom Mar 6, 2023
edreamleo:ekr-_handle_first_parameter
Merged
PR: Remove a do-nothing statement in soi._handle_first_parameter#680lieryan merged 1 commit intopython-rope:masterfrom edreamleo:ekr-_handle_first_parameter
lieryan merged 1 commit intopython-rope:masterfrom
edreamleo:ekr-_handle_first_parameter
Conversation
Member
|
Hi @edreamleo, thanks for fixing this. I wonder what was the intent for this empty block was. If I had to guess, this was probably supposed to be an if--elif chain and the empty block was supposed to be an early return from the method. Not quite sure whether the lack of early return would have caused any issues, but if it's been a decade without an issue, removing it probably would be fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
then-clauseof anifstatement waspass.