Skip to content

PR: Remove a do-nothing statement in soi._handle_first_parameter#680

Merged
lieryan merged 1 commit intopython-rope:masterfrom
edreamleo:ekr-_handle_first_parameter
Mar 6, 2023
Merged

PR: Remove a do-nothing statement in soi._handle_first_parameter#680
lieryan merged 1 commit intopython-rope:masterfrom
edreamleo:ekr-_handle_first_parameter

Conversation

@edreamleo
Copy link
Copy Markdown
Contributor

@edreamleo edreamleo commented Mar 5, 2023

The then-clause of an if statement was pass.

@lieryan
Copy link
Copy Markdown
Member

lieryan commented Mar 6, 2023

Hi @edreamleo, thanks for fixing this.

I wonder what was the intent for this empty block was.

If I had to guess, this was probably supposed to be an if--elif chain and the empty block was supposed to be an early return from the method.

Not quite sure whether the lack of early return would have caused any issues, but if it's been a decade without an issue, removing it probably would be fine.

@lieryan lieryan merged commit 35569ac into python-rope:master Mar 6, 2023
@lieryan lieryan added this to the 1.8.0 milestone May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants