PR: Use single inheritance for Rope's object classes#675
Closed
edreamleo wants to merge 3 commits intopython-rope:masterfrom
edreamleo:ekr-single-inheritence
Closed
PR: Use single inheritance for Rope's object classes#675edreamleo wants to merge 3 commits intopython-rope:masterfrom edreamleo:ekr-single-inheritence
edreamleo wants to merge 3 commits intopython-rope:masterfrom
edreamleo:ekr-single-inheritence
Conversation
Member
|
This change does not look correct to me. AbstractFunction classes defines the interface for what it means to be a function, it just provides a default implementation so that subclasses don't have to implement anything if it doesn't need to implement something, ditto with the others. Defining empty interface immediately screams that something is wrong with the new version of Abstract classes. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for ekr-fork-rope2 #4.
Step 1: Remove all methods from the three
Abstractclasses, moving:AbstractClass.get_superclassestopyobjects.PyClassandbuiltins.BuiltinClass.AbstractFunction.get_param_namesandAbstractFunction.get_returned_objectto pyobjects.PyFunction`.Step2: Make
PyDefinedObjecta subclass ofPyObject.