Add _FilterArgs NamedTuple to ImageFilter - #9968
Open
radarhere wants to merge 2 commits into
Open
Conversation
akx
reviewed
Sep 7, 2026
akx
left a comment
Contributor
There was a problem hiding this comment.
I like the idea. Minor comments - things I had to look up to understand the flow, so maybe someone else would have to, too :)
|
|
||
| class _FilterArgs(NamedTuple): | ||
| size: tuple[int, int] | ||
| scale: float |
Contributor
There was a problem hiding this comment.
I'd personally like to call this divisor, because that's what it practically is (and in fact, that's the "argument name" in _filter() in _imaging.c).
Member
Author
There was a problem hiding this comment.
Kernel calls it scale.
Lines 72 to 78 in 5eee920
I would rather be consistent with the existing Python API.
| pass | ||
|
|
||
|
|
||
| class _FilterArgs(NamedTuple): |
Contributor
There was a problem hiding this comment.
I'd kind of want to note that these are unpacked directly to ImagingCore.filter().
Member
Author
There was a problem hiding this comment.
Ok, I've added a comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See if you think this makes the code clearer.