Improve error messages from C - #9784
Open
akx wants to merge 4 commits into
Open
Conversation
akx
marked this pull request as ready for review
July 9, 2026 11:59
radarhere
reviewed
Jul 17, 2026
akx
force-pushed
the
wrong-mode-exc
branch
3 times, most recently
from
July 20, 2026 07:31
fbf0a1d to
5b9e30f
Compare
Contributor
Author
|
Rebased post #9794. |
akx
marked this pull request as draft
August 31, 2026 06:42
akx
force-pushed
the
wrong-mode-exc
branch
2 times, most recently
from
August 31, 2026 06:49
92f9165 to
31a972d
Compare
akx
marked this pull request as ready for review
August 31, 2026 06:50
radarhere
reviewed
Sep 7, 2026
akx
force-pushed
the
wrong-mode-exc
branch
2 times, most recently
from
September 7, 2026 12:31
49db676 to
3a45fc5
Compare
Merging this PR will improve performance by 10.94%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | test_scale[1237x811-I-2.14-NEAREST] |
101.8 ms | 91 ms | +11.86% |
| ⚡ | test_scale[1237x811-RGB-2.14-NEAREST] |
101.9 ms | 91.1 ms | +11.86% |
| ⚡ | test_scale[1237x811-LA-2.14-NEAREST] |
101.9 ms | 91.1 ms | +11.85% |
| ⚡ | test_scale[1237x811-RGBA-2.14-NEAREST] |
101.9 ms | 91.1 ms | +11.84% |
| ⚡ | test_scale[1237x811-F-2.14-NEAREST] |
101.9 ms | 91.1 ms | +11.77% |
| ⚡ | test_scale[1237x811-F-0.8-NEAREST] |
16.5 ms | 15 ms | +10.05% |
| ⚡ | test_scale[1237x811-LA-0.8-NEAREST] |
16.5 ms | 15 ms | +10.05% |
| ⚡ | test_scale[1237x811-RGB-0.8-NEAREST] |
16.5 ms | 15 ms | +10.05% |
| ⚡ | test_scale[1237x811-RGBA-0.8-NEAREST] |
16.5 ms | 15 ms | +10.05% |
| ⚡ | test_scale[1237x811-I-0.8-NEAREST] |
16.5 ms | 15 ms | +10.05% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing akx:wrong-mode-exc (11dc2fc) with main (0a61c53)
Footnotes
-
335 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
radarhere
reviewed
Sep 13, 2026
radarhere
reviewed
Sep 13, 2026
Co-authored-by: Andrew Murray <radarhere@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #6667 (comment)
NotSupportedErrorfor operations that are currently not supported; derives from bothValueErrorandNotImplementedErrorfor backward compatibility.NotImplementedErrorallows for try-excepting in tests, so we can do better than (e.g.)Tests.test_image_filter.test_sanitywhere the test just quietly does nothing when a mode combo is not (yet, or currently) supported. (This wasn't wired up here yet.)ImagingError_*()C APIs now all support an optional message text, and message texts were added where practical. No longer "image has wrong mode" or "images do not match" for everything! ✨