Added underline support to Runs#28
Closed
onlyjus wants to merge 24 commits intopython-openxml:masterfrom
onlyjus:master
Closed
Added underline support to Runs#28onlyjus wants to merge 24 commits intopython-openxml:masterfrom onlyjus:master
onlyjus wants to merge 24 commits intopython-openxml:masterfrom
onlyjus:master
Conversation
added basic underline feature, hopefully figure out how to expand it to allow for all underline options. i.e. 'double', 'dash', etc.
added basic underline support. i.e. `.underline=True` Hopefully add more support in the future for 'single', 'double', 'dash', etc.
Added an attribute that can hold a underline style string.
It can handle all the underline types.
Contributor
Author
|
Don't merge it yet I am working on cleaning it up. Need to add tests. |
underline module almost done, need to work on tests. created class for `<w:tcPr>` to handle cell properties like `gridSpan`
Contributor
Author
There was a problem hiding this comment.
Should we do any error checking before this line? Actually, we should probably move it to do the conversion from WD_UNDERLINE to string into docx/omxl/text.py.
Contributor
Author
There was a problem hiding this comment.
Do we want to use colSpan in the api or gridSpan?
Added bool prop tests for underline. Moved from `WD_UNDERLINE` conversion to string into `docx\oxml\text.py`
Can now set column spans and cell shading properties.
Closed
corrected errors in test_text.
dumb error from copy/paste.
Contributor
|
Coming along nicely Justin. Let's get the acceptance test(s) in place so we can start taking the commits one at a time. Let me know with any questions :) |
Cleaned up code to follow standards.
added CT_jc and CT_textDirection functions and got them working.
trying to get tests working locally.
This reverts commit f8d30ff.
trying some edits to see if it will work
another attempt at getting it to work.
I don't really know what I am doing...
This should work....
Contributor
Author
|
Finally I got the underline test working! |
Contributor
|
Great, thanks Justin, I'll take a look after work :) |
Contributor
|
Merged and released as v0.5.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some code to allow for underlining words via runs:
`p.add_run('underlines!').underline = WD_UNDERLINE.DOUBLE
Supports all of word's underline styles:
'single', 'words', 'double', 'thick', 'dotted', 'dottedHeavy', 'dash', 'dashedHeavy', 'dashLong', 'dashLongHeavy', 'dotDash', 'dashDotHeavy', 'dotDotDash', 'dashDotDotHeavy','wave', 'wavyHeavy', 'wavyDouble', 'none'