Repository navigation
Conversation
Wkhanex
reviewed
Oct 14, 2026
Wkhanex
left a comment
There was a problem hiding this comment.
With a small injected catalog scale/pattern table, intword selects the correct named power, preserves the negative sign and leaves values below the first scale as numbers. Empty, unsorted, duplicate, boolean, excessive and malformed scale metadata all fall back to the legacy formatter. These checks use catalog-function substitutes rather than compiled Japanese catalogs.
Checked 5eb2a8de211b with 11 standalone assertions on Python 3.12.14. I haven't run the full suite. The generated _version module was supplied as metadata only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #181
Changes proposed in this pull request:
234909023becomes2.3億and2349090becomes234.9万. Preserve the existing formatting path for catalogs that do not opt in.Validation: 873 ordinary tests passed on Python 3.13; Ruff 0.16.5, Black 26.5.1, Prettier 3.9.6, and mypy passed. The 15 benchmark tests were not run because their plugins were unavailable. A separate bounded timing check measured about 0.16 microseconds of additional overhead for English
intwordcalls.This uses new opt-in catalog entries and leaves existing unit message IDs in place, keeping the change separate from the placeholder migration in #403. The existing French plural-selection rule and the English decillion/googol gap are unchanged.