Backports some patches to Python 2.7 branch#339
Merged
HorlogeSkynet merged 14 commits intopython2.7-supportfrom Jun 21, 2022
Merged
Backports some patches to Python 2.7 branch#339HorlogeSkynet merged 14 commits intopython2.7-supportfrom
HorlogeSkynet merged 14 commits intopython2.7-supportfrom
Conversation
A development convenience to pass arguments like -v -x and others. See: https://tox.wiki/en/latest/config.html#substitutions-for-positional-arguments-in-commands
... and remove `amazon` from "missing distributions" test cases list > closes #252
This allows executing the file as a standalone script.
Previously, without the shebang, trying to execute results in the
following:
$ ./distro.py
./distro.py: line 28: platform.linux_distribution: command not found
./distro.py: line 28: platform.dist: command not found
./distro.py: line 28: Python: command not found
./distro.py: command substitution: line 29: syntax error near unexpected token `newline'
./distro.py: command substitution: line 29: `<https://bugs.python.org/issue1322>'
...
Now:
$ ./distro.py
Name: Fedora 34 (Workstation Edition)
Version: 34
Codename:
distro#230 introduced proper support for os-release `VERSION_CODENAME` attribute but broke compatibility shim with (now defunct) `platform.linux_distribution` as the third tuple member (codename) were not taken from `VERSION` os-release attribute anymore. Closes #238.
`subprocess.CalledProcessError` exceptions are now caught since 9260b7b
> closes #303
nir0s
approved these changes
Jun 20, 2022
Collaborator
nir0s
left a comment
nir0s
left a comment
There was a problem hiding this comment.
Overall LGTM. I admit that I'm not following up on each and every change, though.
Member
Author
I've "only" cherry-picked commits that could easily be applied, the other ones are left for those who would need them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PS : I had to adapt #331 due Python 2.7 support drop by upstream
blackand underlyingclickdependency...