Repository navigation
Correct past and future directions for datetime durations - #247
Open
saitakarcesme wants to merge 1 commit into
Open
saitakarcesme wants to merge 1 commit into
saitakarcesme wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #246.
With
add_direction=True, a datetime one hour in the past currently producesin 1 hour, while a future datetime produces1 hour ago. Subtract the current time from the supplied datetime so its sign follows Babel's duration convention. Direct timedelta values retain their existing meaning; output without direction stays the same.Tests cover past/future datetime inputs, positive/negative timedelta controls, the Jinja
timedeltaformatfilter, and output without direction. The clock is fixed without adding a test dependency. The docstring and changelog describe the corrected behavior.This addresses direction separately from the timezone-aware datetime support proposed in #233; that PR currently retains the old subtraction order. No timezone-awareness changes are included here.
Validation (macOS, Python 3.13.5, Flask 3.1.3, Babel 2.18.0, pytest 7.4.4):
git archive HEADbaseline has 30 pass, the same 3 fail:test_list_translations,test_list_translations_default_locale_exists, andtest_multiple_directories. All three assume directory iteration order; the existing Fix list-translations() ordering in tests #242 addresses ordering in these tests.-Wpasses.Prepared and tested with OpenAI Codex.