Repository navigation
Fix tab-separated PO locations with enclosed filenames - #1384
Open
Aurantium-47 wants to merge 2 commits into
Open
Aurantium-47 wants to merge 2 commits into
Aurantium-47 wants to merge 2 commits into
Conversation
Assisted-by: OpenAI GPT-6 <noreply@openai.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a PO location comment contains an FSI/PDI-enclosed filename, the parser only treats spaces as separators. A tab between references is then retained as part of a filename (or becomes a spurious reference when surrounded by spaces). Comments without enclosed filenames already accept tab separators.
Treat tabs outside the filename enclosure as separators too, while preserving tabs inside enclosed filenames. The regression tests exercise
read_powith plain and enclosed filenames, tab-only separators, and mixed space/tab separators.Validation on Windows with Python 3.12:
python -m pytest tests/messages -q: 389 passed, one existing pytest deprecation warning, with CLDR 48.2 imported using the repository script.git diff --checkpasses.AI assistance: implementation, tests, and this description were prepared with OpenAI Codex; the patch received a separate AI code review.
Validation after upstream conflict resolution (2026-11-02)
At
5684a928191b7807722111e02df64fcabb33f791, both the original tab-separator regression tests and the new upstream source-reference tests are retained. The change against master7576e5da9747336b5702f4414aff0bb84690450aremains two files, 21 additions and one deletion.On Linux with Python 3.12.14 and CLDR 48.2:
python -m pytest -q: 7,944 passed, 7 skipped, 2 xfailed; one existing pytest parametrization deprecation warning.python -m pytest tests/messages -q: 451 passed.git diff --checkpass.The remote tree was verified against the locally tested tree. GitHub CI and Security workflows currently await maintainer approval; the local results above are not a claim that upstream CI has passed.